Skip to content

Only test register_handler in a single thread - #8501

Closed
radarhere wants to merge 4 commits into
python-pillow:mainfrom
radarhere:register_handler
Closed

Only test register_handler in a single thread#8501
radarhere wants to merge 4 commits into
python-pillow:mainfrom
radarhere:register_handler

Conversation

@radarhere

@radarhere radarhere commented Oct 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Possible way to help #8492. Alternative to #8518

The issue has found that running a test that calls register_handler at the beginning, and removes the handler at the end, fails when the test is run across multiple threads.

My thinking is that if it ok for register_handler to operate across threads, and that it doesn't need to register multiple handlers in parallel. So this PR returns early from the relevant test if it is already running in another thread.

@radarhere radarhere mentioned this pull request Oct 26, 2024
Open
@radarhere radarhere added the Free-threading PEP 703 support label Oct 29, 2024
lysnikolaou
lysnikolaou reviewed Nov 1, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also been working on fixing some of these issues. Since you think we should leave these alone in #8492 (comment), I think we should mark the tests with @pytest.mark.parallel_threads(1) instead.

@radarhere radarhere mentioned this pull request Nov 1, 2024
Closed
@radarhere

radarhere commented Nov 1, 2024

Copy link
Copy Markdown
Member Author

Is it a problem that pytest.mark.parallel_threads would only work for pytest-run-parallel? We've also had #8454 from a person using https://github.com/tonybaloney/pytest-freethreaded. If that happens again, do we need to ask such a user to change testing tools?

#8518 is another idea I had.

@lysnikolaou

lysnikolaou commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Is it a problem that pytest.mark.parallel_threads would only work for pytest-run-parallel? We've also had #8454 from a person using tonybaloney/pytest-freethreaded. If that happens again, do we need to ask such a user to change testing tools?

I'm not sure about that to be honest. I'm using pytest-run-parallel cause I like the fact that the default is a single thread. The best solution here would be to have a @pytest.mark.thread_unsafe mark that would work across plugins. I can coordinate doing that.

@radarhere radarhere closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lysnikolaou lysnikolaou lysnikolaou left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Free-threading PEP 703 support Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @lysnikolaou