Repository navigation
Conversation
lysnikolaou
reviewed
Nov 1, 2024
Comment on lines
+176
to
+179
| if identifier in already_running: | ||
| return True | ||
|
|
||
| already_running.append(identifier) |
Contributor
There was a problem hiding this comment.
I think that this introduces another possible race, where two or more threads all think that the test is not currently running elsewhere and add themselves to the list.
lysnikolaou
reviewed
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible way to help #8492. Alternative to #8501
I've created a Tests/helper.py function called
running_in_another_thread()that uses a global variable andinspectto determine if a test has already started running in another thread, so that we can return early if we would only like the test to run in one thread at a time.This is used here in two cases
register_handlerat the beginning, and removes the handler at the end, fails when the test is run across multiple threads. My thinking is that if it ok forregister_handlerto operate across threads, and that it doesn't need to register multiple handlers in parallel. So this PR returns early from the relevant test if it is already running in another thread.Pillow/Tests/test_core_resources.py
Lines 50 to 54 in 16372dd
across multiple threads. I again think that
Image.core.set_alignmentdoesn't need to be run across multiple threads simultaneously, so this PR returns early.