Repository navigation
Allow --no-tag to overwrite --commit #949
Description
Description
This is related to the command semantic-release version:
I would like to run semantic-release without tags for this use case where another process creates a tag.
However as described in the documentation --no-tag doesn't apply to the --commit step.
Is there a reason that --no-tag only applies to the tagging step?
Would it be possible for --no-tag to also apply to the --commit step?
Use cases
With the current setup running --commit makes --tag/--no-tag useless as it will never create a tag different from the tag that is created by --commit, is that right? If that's the case, then there shouldn't be anything in the way for us to set it up so that --no-tag also applies to the tag created by --commit.
Possible implementation
I'd be happy of course to create a PR but wanted to check with what you all think.
Activity
codejedi365 commentedon Jun 8, 2024
It's more of a historic thing that is not evaluated together. I added the
--tag/--no-tagbecause my migration from v7 to v8 was broken while--commit/--no-commitexisted already. I personally wanted to just use PSR to stamp the version into my codebase and run the build command and then stop which required--no-commitand--no-tag. Otherwise I had to manually remove the tag (I wasn't releasing yet). I made--tag/--no-tagmirror the commit option and separated the two actions and left commit as it was. I was not an advocate for the use of a version commit so I just left the commit options alone as I was fairly new to the project.We already have the
--push/--no-pushaction dependent on--tagand--commitso it would probably just be considered at the same point in the code. As for if it should...Yes, creating a commit with the version identified is kinda silly if you don't end up tagging it. PSR no longer reads commit messages to determine versions, so it would identify the same version from the same set of tags regardless if the last commit was a version commit or not. To be clear though,
--commitdoes NOT create a tag.To summarize the result:
--no-tagimplies--no-commit--tagdoes NOT imply--commitwhich means:
--commit--tag--no-commit--tag--commit--no-tag--no-commit--no-tagAfter writing this, yes I don't think this will cause any problems to have one imply the other, however, I do believe this will be a breaking change when added.
beatreichenbach commentedon Jun 16, 2024
Hi @codejedi365,
thank you so much for the detailed explanation. Sorry it took me a while to really grasp everything. I went though the code and made a pull request that I believe in the end actually makes some of these arguments more explicit.
Now it is possible to do really almost anything. It is possible to only create a tag, to only create a commit and to push those independently. The biggest change is really just that we can now create a commit without a tag which can be helpful in some very niche circumstances.
I did mark it with a breaking fix, as it changes the behavior of
--commit --no-tag.codejedi365 commentedon Sep 15, 2024
Looking to implement as part of the
v10release.github-actions commentedon Nov 15, 2024
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?
codejedi365 commentedon Nov 15, 2024
Still in backlog as I haven't done much of the v10 breaking change items yet but getting close
github-actions commentedon Jan 16, 2025
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?
2 remaining items
github-actions commentedon Mar 20, 2025
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?
codejedi365 commentedon Mar 21, 2025
Still in backlog
github-actions commentedon May 21, 2025
It has been 60 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?
codejedi365 commentedon May 21, 2025
Still in backlog
github-actions commentedon Aug 20, 2025
It has been 90 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?
codejedi365 commentedon Oct 3, 2025
Still in backlog
github-actions commentedon Jan 1, 2026
It has been 90 days since the last update on this confirmed issue. @python-semantic-release/team can you provide an update on the status of this issue?