Repository navigation
Conversation
This is far from ideal, but it seems to be the easiest way to expose the
require.dumpCache method for use by require("mock-modules").dumpCache.
Upstream patch that would make this hack unnecessary if accepted:
browserify/browser-pack#16
Contributor
There was a problem hiding this comment.
We should do our multiline strings the same way in the same file... We should maybe put them in a new file and read them in too...
Contributor
Author
|
Accidentally closed. Confused by GitHub IRC bot. #156 is still open. |
Merged
Contributor
Author
|
Superseded by #193. |
Fran-web-dev
added a commit
to Fran-web-dev/react
that referenced
this pull request
Oct 11, 2026
When a Suspense reveal commit is throttled (deferred to a setTimeout), the commit's pending-effects flush can run passive effects from another root that synchronously update this root — e.g. a useSyncExternalStore write or a flushSync. The resulting sync render commits this root, possibly the exact tree the deferred commit was holding, and the invariant `finishedWork === root.current` throws "Cannot commit the same tree as before" (react#177). Since react#31930, `finishedWork` is passed as an argument, so it's no longer recomputed after the flush like it was in 19.0.0, where the stale commit returned early because root.finishedWork had been reset to null. Bail out of the commit if a synchronous render intervened during the flush — either it already committed a new tree on this root (possibly this exact one) or it left a partially rendered one behind. Any lanes the commit was carrying remain pending and are rendered again on the next attempt. The invariant is preserved for the case where nothing intervened. Fixes react#37762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from ideal, but it seems to be the easiest way to expose the
require.dumpCachemethod for use byrequire("mock-modules").dumpCache.Upstream patch that would make this hack unnecessary if accepted:
browserify/browser-pack#16
cc @jeffmo @zpao