Skip to content

[Fiber] Support moveBefore at the top level of a container - #32036

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:movebefore
Jan 9, 2025
Merged

[Fiber] Support moveBefore at the top level of a container#32036
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:movebefore

Conversation

@sebmarkbage

@sebmarkbage sebmarkbage commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Parity with appendChild and insertBefore. This allows reordering at the root while preserving state.

@sebmarkbage
sebmarkbage requested a review from gnoff January 9, 2025 21:22
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 9, 2025
@react-sizebot

react-sizebot commented Jan 9, 2025

Copy link
Copy Markdown

Comparing: d2a1b8854d5c4bed713e7e732b598d88e3cc4858...d2435167557b87e930d245492f14e774c04dff37

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 513.98 kB 513.98 kB = 91.79 kB 91.79 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 548.08 kB 548.01 kB = 97.52 kB 97.51 kB
facebook-www/ReactDOM-prod.classic.js = 595.86 kB 595.86 kB = 104.87 kB 104.87 kB
facebook-www/ReactDOM-prod.modern.js = 586.29 kB 586.29 kB = 103.32 kB 103.32 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-prod.fb.js +0.89% 379.36 kB 382.72 kB +0.99% 65.85 kB 66.50 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.87% 384.79 kB 388.16 kB +1.00% 66.80 kB 67.47 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.83% 404.85 kB 408.21 kB +0.95% 69.70 kB 70.36 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.82% 410.25 kB 413.62 kB +0.91% 70.62 kB 71.26 kB

Generated by 🚫 dangerJS against dfbceb9

@sebmarkbage
sebmarkbage merged commit 056073d into react:main Jan 9, 2025
github-actions Bot pushed a commit that referenced this pull request Jan 9, 2025
@sebmarkbage
[Fiber] Support moveBefore at the top level of a container (#32036)
56d6772 
Parity with appendChild and insertBefore. This allows reordering at the
root while preserving state.

DiffTrain build for [056073d](056073d)
github-actions Bot pushed a commit to code/lib-react that referenced this pull request Jan 10, 2025
@pull
[Fiber] Support moveBefore at the top level of a container (react#32036)
a6512b7 
Parity with appendChild and insertBefore. This allows reordering at the
root while preserving state.

DiffTrain build for [056073d](react@056073d)
@vercel-release-bot vercel-release-bot mentioned this pull request Jan 10, 2025
Merged
@Hardelzs

Hardelzs commented Feb 24, 2025

Copy link
Copy Markdown

This development is significant for web developers, as it offers a more efficient way to manage dynamic content updates without losing the current state of elements.

This branch was successfully deployed

1 active deployment
Preview — dfbceb9a Deployed Jan 9, 2025 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff gnoff approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebmarkbage @react-sizebot @Hardelzs @gnoff @facebook-github-bot