Repository navigation
[Flight] Fix preload as attribute for stylesheets - #34760
Merged
Merged
Conversation
Follow-up to react#34604. For a stylesheet, we need to render `<link rel="preload" as="style" ...>`, and not `<link rel="preload" as="stylesheet" ...>`. ([ref](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/rel/preload#what_types_of_content_can_be_preloaded)) fixes vercel/next.js#84569
github-actions
Bot
added
the
React Core Team
|
Comparing: a4eb2df...ebaef91 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Oct 10, 2025
9 of 11 tasks
yannvr
added a commit
to hyperdrift-io/own-stack
that referenced
this pull request
Oct 8, 2026
React 19.3 carries react/react#34760, which ends the 60-second blank page when a dynamic page throws not-found mid-stream under a layout that imports CSS. Waku's peer range has required it since rc.1. No code changes: this app has no _root.tsx, so the default root now renders charset and viewport (rc.2), and it uses file routes only, so rc.3's defineRouter redesign does not touch it. The waku pin stays exact. Checked: type-check, build, tests, and the production build serving / 200, /health 200 and an unknown path 404.
yannvr
added a commit
to hyperdrift-io/stillness
that referenced
this pull request
Oct 8, 2026
React 19.3 is Waku's peer range since rc.1 and carries react/react#34760 (no 60 s blank page when a page throws not-found mid-stream under a layout that imports CSS). rc.2 moved charset and viewport out of the framework head into the default root, so the custom _root.tsx renders both now. File routes only, so rc.3's defineRouter redesign does not apply. Checked: type-check, build, the production build serving / 200, /llms.txt 200 and an unknown path 404, and the home page hydrating in the browser with both meta tags present once.
yannvr
added a commit
to hyperdrift-io/unanswered
that referenced
this pull request
Oct 8, 2026
React 19.3 is Waku's peer range since rc.1 and carries react/react#34760 (no 60 s blank page when a page throws not-found mid-stream under a layout that imports CSS). No code changes: no custom _root.tsx, so the default root renders charset and viewport (rc.2), and file routes only, so rc.3's defineRouter redesign does not apply. Installed past the 3-day min-release-age guard: waku rc.3 is two days old, has provenance attestations and no OSV advisory. Checked: type-check, build, tests (6 pass), and the production build serving / 200, /health 200, /llms.txt 200 and an unknown path 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34604. For a stylesheet, we need to render
<link rel="preload" as="style" ...>, and not<link rel="preload" as="stylesheet" ...>. (ref)fixes vercel/next.js#84569