Repository navigation
ENH: Add regularization to the main NMF class - #17414
Merged
Merged
Conversation
adrinjalali
reviewed
Jul 14, 2020
adrinjalali
left a comment
adrinjalali
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @Bharat123rox
Update `_nmf.py` with suggestion from review Co-authored-by: Adrin Jalali <[email protected]>
Contributor
Author
|
Doc failures seem to be intermittent, or a build failure from CircleCI which are unrelated to these changes 😞 |
thomasjpfan
reviewed
Jul 14, 2020
thomasjpfan
left a comment
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @Bharat123rox !
sadakmed
approved these changes
Aug 2, 2020
Contributor
|
@Bharat123rox something went wrong in CircleCI, unrelated with your PR: do you mind fixing conflicts in order to trigger the build? Thanks! |
TomDLT
approved these changes
Aug 3, 2020
TomDLT
left a comment
TomDLT
left a comment
Member
There was a problem hiding this comment.
Nice job !
You might want to add a changelog entry in doc/whats_new/0.24.rst.
thomasjpfan
reviewed
Aug 3, 2020
bharatr21
commented
Aug 5, 2020
thomasjpfan
approved these changes
Aug 6, 2020
|
|
||
| class NMF(TransformerMixin, BaseEstimator): | ||
| r"""Non-Negative Matrix Factorization (NMF) | ||
| """Non-Negative Matrix Factorization (NMF) |
Member
There was a problem hiding this comment.
This was to make
regularization : {'both', 'components', 'transformation', None}, \
default='both'work with the \. I do not think there is a way to ignore the newline in a raw string.
XREF: numpy/numpydoc#87
Member
|
Thanks @Bharat123rox ! |
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
* ENH: Add regularization to the main NMF class * Update _nmf with suggestions from code review Update `_nmf.py` with suggestion from review Co-authored-by: Adrin Jalali <[email protected]> * Refactor tests, fix linter errors * Change default value to None * Revert back to default value of "both" * Update default value documentation acc to @thomasjpfan Co-authored-by: Thomas J. Fan <[email protected]> * CLN Places regularization at the end * Add whatsnew entry * DOC Fix * DOC Fix Co-authored-by: Adrin Jalali <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12520
What does this implement/fix? Explain your changes.
Introduces the
regularizationparameter to the mainNMF()class instead of just the publicnon_negative_factorizationpublic functionAny other comments?
Need guidance on how to add tests to the
test_nmf_regularization()Tagging @adrinjalali for PR review, based on the issue