Repository navigation
ENH Add support for 'fit_params' to learning_curve - #18595
Merged
thomasjpfan merged 5 commits intoOct 14, 2020
Merged
Conversation
amy12xx
changed the title
amy12xx
changed the title
amy12xx
marked this pull request as ready for review
October 11, 2020 07:37
amy12xx
changed the title
ogrisel
reviewed
Oct 14, 2020
| def __init__(self, n_max_train_sizes, expected_fit_params=None): | ||
| super().__init__(n_max_train_sizes) | ||
| self.x = None | ||
| self.expected_fit_params = expected_fit_params |
Member
There was a problem hiding this comment.
@thomasjpfan I believe this is what you requested in #18527. Looks good to me.
Contributor
Author
|
@ogrisel this seems to be an error unrelated to this PR. Any suggestions if I need to do something here? |
Member
|
This was fixed in master by #18617. I think you need to merge master in that branch again. |
Member
|
I just pushed a merge of master to your branch. Let's see... |
thomasjpfan
changed the title
amrcode
pushed a commit
to amrcode/scikit-learn
that referenced
this pull request
Oct 19, 2020
Co-authored-by: Olivier Grisel <[email protected]>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Olivier Grisel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10252
What does this implement/fix? Explain your changes.
Add fit_params support to learning_curve
Any other comments?