Repository navigation
BUG Add tol to _make_unique to avoid inf values in IsotonicRegression - #18639
Merged
Merged
Conversation
ogrisel
reviewed
Oct 21, 2020
ogrisel
reviewed
Oct 21, 2020
Member
|
Could you please add a new non-regression test for |
ogrisel
reviewed
Oct 22, 2020
ogrisel
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this nasty bug @lucyleeow! Here are a few more suggestions for improvements. But otherwise LGTM.
Member
|
FYI, I merged the master branch that has a fix for the unrelated failing macOS CI. |
Member
Author
|
Thanks for the suggestions @ogrisel, added! |
ogrisel
reviewed
Oct 23, 2020
ogrisel
approved these changes
Oct 23, 2020
ogrisel
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Can you please add a new entry for doc/whats_new/0.24.rst?
Member
Author
|
Maybe 2nd review @glemaitre 😄 ? |
agramfort
approved these changes
Oct 27, 2020
Member
|
thanks @lucyleeow ! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10903
Closes #10981 and #17758
What does this implement/fix? Explain your changes.
Add a tol when checking equality in
_make_unique, such that values are deemed unique only if their difference is greater or equal than 1e-15 i.e.:this agrees with Python:
Note that this is not the case for 0:
see more here: #17758 (comment)
Any other comments?
Also removed
current_countas it does not seem to be used anymore (as discussed with @ogrisel)cc @ogrisel