Skip to content

Use Numpy 1.22.2 instead of 1.22.0 - #58

Merged
rgommers merged 3 commits into
scipy:mainfrom
lpsinger:numpy-1.22
May 28, 2022
Merged

rgommers merged 3 commits into
scipy:mainfrom
lpsinger:numpy-1.22

Conversation

@lpsinger

Copy link
Copy Markdown
Contributor

Numpy 1.22.0 had a regression that prevented building packages against the Python limited C API, that was fixed in Numpy 1.22.2. See numpy/numpy#20818.

This is causes build failures for my Astropy affiliated package (https://git.ligo.org/lscsoft/ligo.skymap), which like many Astropy affiliated package, depends on oldest-supported-numpy.

lpsinger and others added 2 commits May 27, 2022 18:28
Numpy 1.22.0 had a regression that prevented building packages
against the Python limited C API, that was fixed in Numpy 1.22.2.

See numpy/numpy#20818.

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lpsinger. I've added a comment with this rationale.

@rgommers
rgommers merged commit 4aace24 into scipy:main May 28, 2022
@rgommers

Copy link
Copy Markdown
Member

@lpsinger
lpsinger deleted the numpy-1.22 branch May 30, 2022 01:09
lpsinger added a commit to lpsinger/oldest-supported-numpy that referenced this pull request Jun 2, 2022
This is a follow up to scipy#58. The Numpy regression fixed in numpy/numpy#20818
was introduced in Numpy 1.21.0, not 1.22.0. My mistake. Sorry!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants