Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maven-javadoc-plugin moved the javadoc goal's output from target/site/apidocs to target/reports/apidocs in 3.11, and this branch pins 3.11.3. The script still copies from target/site, so the glob never matches, mv fails, and api/ publishes empty. The frozen scylla-3.*.x branches pin 2.10.4, which is why scylla-3.x has gone unnoticed: it is not a published docs version yet. Resolve from either location, clear both first so the fallback is unambiguous, and require a real non-empty index.html. Build only driver-core: with set -e in force, a javadoc failure in another module would otherwise cost the whole api/. Fixes scylladb#1123 Refs: scylladb#1080, scylladb#1118 Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
maven-javadoc-plugin moved the javadoc goal's output from target/site/apidocs to target/reports/apidocs in 3.11, and this branch pins 3.11.3. The script still copies from target/site, so the glob never matches, mv fails, and api/ publishes empty. The frozen scylla-3.*.x branches pin 2.10.4, which is why scylla-3.x has gone unnoticed: it is not a published docs version yet. Resolve from either location, clear both first so the fallback is unambiguous, and require a real non-empty index.html. Build only driver-core: with set -e in force, a javadoc failure in another module would otherwise cost the whole api/. Fixes #1123 Refs: #1080, #1118 Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
scylla-3.x is not in BRANCHES, so the newest published 3.x docs come from scylla-3.11.5.x, frozen 2025-06-02 at 3.11.5.7 -- eleven releases behind 3.11.5.18, which ships from scylla-3.x. 134 commits are stranded, including the scylladb#919 deprecation notice. Publish it, and mark it deprecated so it keeps the caution banner. Empty hide_version_dropdown: 308ccd8 added the name in the same commit that first published the branch, and the sitemap covers only /stable/, so hiding it leaves the docs reachable by direct URL alone. REAL_ALL tracks BRANCHES, so the guard's fixtures gain the version. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
ee2e9ed to
23f65ee
Compare
|
Closing: publishing the generic line branch is the wrong shape, and the version dropdown is why.
Every A deprecated maintenance branch above current stable, with no deprecation marker in the selector There is a second reason. The theme renders only Superseded by cutting precise version branches instead: |
scylla-3.xis not inBRANCHES, so the newest published 3.x docs come fromscylla-3.11.5.x— abranch frozen 2025-06-02,
pom.xmlat 3.11.5.7. The releases moved: tags3.11.5.16,.17and.18are all cut fromscylla-3.x, along with the release-plugin commits. So someone who installs3.11.5.18 and reads
/scylla-3.11.5.x/gets documentation for a build eleven patch releases older,under a name implying it covers their version.
scylla-3.xtoBRANCHES, and toDEPRECATED_VERSIONSso it keeps the caution banner.hide_version_dropdown.308ccd8e94putscylla-3.xthere in the same commit that firstpublished it — build the then-default branch, don't advertise it. Since
sitemap_url_schemecovers only
/stable/, keeping it would leave the branch reachable by direct URL alone.scylla-3.xto the guard fixtures'REAL_ALL, which tracksBRANCHES.134 commits of content become visible, including #1081's client-routes section, the 3.11.5.19
upgrade notes, and #919's deprecation notice — which currently has no published home.
Verified with a local
make -C docs multiversionoverscylla-3.x+scylla-4.19.0.x, javadocpost-build stubbed:
3.xappears in the version dropdown, its pages carry the banner with themigration link resolving to
/stable/upgrade_guide/, and the stranded sections render../docs/_utils/check-javadoc-output-test.shpasses, and fails without theREAL_ALLedit. Thejavadoc path for this branch is #1124, already merged. Not covered: the 17-version publish, which
only runs post-merge.
No longer stacked on #1079 — this stands alone on
scylla-4.x, and #1079 will need a rebase.Fixes DRIVER-1083
🤖 Generated with Claude Code