Skip to content

ci: install only the modules javadoc.sh documents - #1138

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:javadoc-install-race
Sep 25, 2026
Merged

ci: install only the modules javadoc.sh documents#1138
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
nikagra:javadoc-install-race

Conversation

@nikagra

@nikagra nikagra commented Sep 24, 2026

Copy link
Copy Markdown

javadoc.sh installs the full reactor with -T 1C. examples names mapper-processor as an annotation processor path, not a dependency, so a parallel build can compile it first; on a -SNAPSHOT version nothing on Central fills the gap and the version publishes without api/.

  • install only core, query-builder, mapper-runtime and what they need (-pl … -am)
  • hoist JAVADOC_MODULES so both Maven calls share it

Verified: reproduced the failure in a local multiversion build of scylla-4.19.0.x at 4.19.0.10-SNAPSHOT (22 threads); with this script the same tree builds under JDK 8 to a 1162-file api/ with core, mapper, querybuilder. The 4.19.2 tree built under JDK 11 in the same four-version run (1118 files). Not run on CI's runner size.

Fixes #1136

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: bb761a6f-ce40-474c-a894-c985a6199aec

📥 Commits

Reviewing files that changed from the base of the PR and between 9167ca1 and dbe025f.

📒 Files selected for processing (1)
  • docs/_utils/javadoc.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The script builds a comma-separated module list from JAVADOC_MODULES. It uses that list to limit Maven installation to the selected modules and their dependencies, and to select modules for Javadoc generation. The install remains single-threaded and skips tests, Javadoc, and the listed checks.

Suggested reviewers: dgarcia360

Priority: ➖ Normal

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to dbe02

The build installs the selected Javadoc modules and their required reactor dependencies, then runs Javadoc separately. No unresolved merge risk is established by the reviewed changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR implements issue #1136's requested scope. docs/_utils/javadoc.sh derives the reactor list from JAVADOC_MODULES and installs only core, query-builder, and mapper-runtime with -am. Th…
Out of Scope Changes check ✅ Passed The reported changes are limited to docs/_utils/javadoc.sh. Module-list reuse, install flags, skipped checks, and comments directly support the issue #1136 fix and Javadoc generation. No unrelated c…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Title check ✅ Passed The title clearly and concisely describes the main change: limiting Javadoc installation to the documented modules.
Description check ✅ Passed The description directly explains the parallel-build failure, the module-selection fix, validation results, and linked issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Sep 24, 2026
Closed
Closed
@nikagra
nikagra marked this pull request as ready for review September 25, 2026 12:39
@nikagra @claude
ci: install only the modules javadoc.sh documents
dbe025f 
The full-reactor install races: examples names mapper-processor as an
annotation processor path, not a dependency, so with -T 1C it can
compile before mapper-processor is installed. On a -SNAPSHOT version
nothing on Central fills the gap, the install fails, and the version
publishes without api/. Reproduced on 4.19.0.10-SNAPSHOT with 22
threads. Install core, query-builder and mapper-runtime with -am, and
skip the checks: check-api-leaks sets its own <skip>, and revapi
fetches from Central. The install drops from 80s to 29s.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@nikagra
nikagra force-pushed the javadoc-install-race branch from 8d4ce98 to dbe025f Compare September 25, 2026 12:42
dkropachev
dkropachev approved these changes Sep 25, 2026
View reviewed changes

@dkropachev dkropachev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hermes could not inspect all repository context needed to support an approval.

@dkropachev
dkropachev merged commit ad45f0e into scylladb:scylla-4.x Sep 25, 2026
4 checks passed
@nikagra nikagra mentioned this pull request Sep 28, 2026
Merged
@nikagra nikagra mentioned this pull request Oct 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ci: javadoc.sh's parallel install races on a SNAPSHOT version

2 participants

@nikagra @dkropachev