Repository navigation
Conversation
Ensure that queries are routed according to learned tablet information.
Previously this test was using strong values in cache to prevent them from disappearing mid-test. Code comments explicitly say so. However at some point with the change to using a decorator for CqlPrepareAsyncProcessor it seems that the test was accidentally changed to use weak values. This change makes the test use a decorator which ignores CacheBuilder passed to it and replaces it with brand new instance that has not yet called `.weakValues()`. Additionally assertion related to preparedStmtCacheRemoveLatch is moved after typeChangeEventLatch since it looks like the latter triggers the former. This part is mainly cosmetic.
It seems that the Scylla images for ccm were not cached correctly, because in contrast to cassandra images the path to them is slightly different. The save step outputs a warning about that but it's not failing the step itself.
* Add config options for advanced shard awareness Adds config options for toggling the feature on and defining port ranges to use. By default the feature will be enabled. * Copy 3.x PortAllocator * Extend ChannelFactory methods with shardId params With advanced shard awareness target shard is a necessary parameter for connecting. Extends non public methods with new parameters and provides one additional public method. Passing `null` as shard id or ShardingInfo will lead to previous non-shard aware behavior. * Enable advanced shard awareness Makes `addMissingChannels` use advanced shard awareness. It will now specify target shard when adding missing channels for specific shards. In case returned channels do not match requested shards warnings are logged. Initial connection to the node works on previous rules, meaning it uses arbitrary local port for connection to arbitrary shard. Adds AdvancedShardAwarenessIT that has several methods displaying the difference between establishing connections with option enabled and disabled. Adds ChannelPoolShardAwareInitTest
This is a mandatory dependency update to resolve a critical Dependabot alert. For more details, see the [Dependabot alerts](https://docs.github.com/en/code-security/dependabot/dependabot-alerts/viewing-and-updating-dependabot-alerts).
This should fix the error in https://github.com/scylladb/java-driver/actions/runs/14710534817, which currently prevents publishing new versions of https://java-driver.docs.scylladb.com/ Rolled back some dependencies in `poetry.lock` to previous versions while we investigate how to make the extension `sphinx_scylladb_markdown` compatible with the latest versions. No need to backport.
Those links redirect to internal API which is not a part of the generated javadoc, leading to 404 on visit. Instead redirect to code on github.
Some of the links in documentation lead to datastax repositories. This change adds patterns that should cover any links to classes or directories of the codebase and make them point to scylladb fork instead.
Created some branches for those versions according to existing format. Note that `scylla-4.19.0.x` corresponds to the latest released `4.19.0.1` and not current master (`scylla-4.x`). If the next released version is `4.19.0.2` then `scylla-4.19.0.x` will need to be moved with whatever documentation backports it has on top of `4.19.0.2`. However it's unlikely that `4.19.0.2` will not have the same changes already, so it should not be an issue.
Valid module for 4.x is "core" and not "driver-core". Wrong path leads to script failing on `mv` step.
Fixes two problems: 1. trigger it for `scylla-4.x` 2. make it non-concurrent
Adds the `scylla-3.11.4.x` and `scylla-3.11.5.x` branches to the config, making them available versions on generated multiversion documentation page.
This option collides with ccm.distribution that was introduced in `4.18.0.0`. Let's remove it to keep code clean.
Parallel tests falsly failing due to the simulateneuse access to ConcurrentMap.put To avoid that let's add it to exception.
Sometimes test can fail to cleanup ccm cluster which will lead to failure of next tests if their IP addresses clashes. To avoid that let's spin every cluster on it's own prefix.
Since cluster is running on it's own ip prefix we can safely run them without specifing particular ip prefix.
Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.13.4 to 2.15.0. - [Changelog](https://github.com/FasterXML/jackson-core/blob/jackson-core-2.15.0/release.properties) - [Commits](FasterXML/jackson-core@jackson-core-2.13.4...jackson-core-2.15.0) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-core dependency-version: 2.15.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sphinx-scylladb-theme](https://github.com/scylladb/sphinx-scylladb-theme) from 1.8.6 to 1.8.7. - [Release notes](https://github.com/scylladb/sphinx-scylladb-theme/releases) - [Commits](scylladb/sphinx-scylladb-theme@1.8.6...1.8.7) --- updated-dependencies: - dependency-name: sphinx-scylladb-theme dependency-version: 1.8.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Go over disabled tests and enable them. If test fails: 1. Make test framework ignore it with proper message 2. If it is scylla bug or test needs to be adjusted, create an issue and reference it 3. Fix test to match scylla behavior There are two ways to disable test for scylla: 1. Mark it with @ScyllaSkip 2. Mark it with any backend requirement annotation: @CassandraRequirement, @DseRequirement, @BackendRequirement; and do not add sylla-specific requirement.
Name does not reflect logic. This annotation makes test framework to skip all non-scylla backends.
Removes DropwizardMetricsIT, MicroProfileMetricsIT, MicrometerMetricsIT from parallelizable tests category, making them serial. Additionally enables MicrometerMetricsIT which was previously ignored due to flakiness. `should_evict_down_node_metrics_when_timeout_fires` in MetricsITBase relies on setting static field `MIN_EXPIRE_AFTER` in AbstractMetricUpdater and then setting it back to 5 minutes. Those three test classes inherit this test method and when they run concurrently it sometimes results in setting the minimal expire time back to 5 minutes before another test initializes its session with expire time set to 1 second. This can be evidenced by the appearance of lines like ``` c.d.o.d.i.c.m.AbstractMetricUpdater - [s6] Value too low for advanced.metrics.node.expire-after: PT1S. Forcing to PT5M instead. ``` whenever that method fails. It does not appear when the test passes (due to lucky schedule). Making those tests serial seems to be the simplest solution.
Bumps [sphinx-scylladb-theme](https://github.com/scylladb/sphinx-scylladb-theme) from 1.8.7 to 1.8.8. - [Release notes](https://github.com/scylladb/sphinx-scylladb-theme/releases) - [Commits](scylladb/sphinx-scylladb-theme@1.8.7...1.8.8) --- updated-dependencies: - dependency-name: sphinx-scylladb-theme dependency-version: 1.8.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Adds isolated SessionTicketsIT which checks if session tickets mechanism behaves as expected. It does that by watching Java's SSL debug logs and ensuring that specific substrings appear in them. Since the server supports tickets with TLSv1.3, only that version is tested. In that version the session resumption without server-side state is done through pre-shared keys. The details are described in rfc8446 (see section 2.2).
When HdrHistogram writes latency if latency is higher than maximum expected it throws error. Driver catches this error and logs it. Users get confused since there is no reciepe how to fix it. Solution is to set advanced.metrics.session.cql-requests.highest-latency to maximum possible latency, which is request timeout. But since request timeout could be configured on the execution profile, we can't automatically tune highest-latency to match it. So, only good solution is to give user a hint in the log message.
Adds a new option that allows for throttling `addMissingChannels()` in `ChannelPool.java`. Instead of creating all missing channels at once for particular channel pool the driver will create batches of limited size and handle them sequentially. Setting size 0 means allowing unlimited batches and it will result in the usual behavior of creating channels all at once. The default value is 0. Setting any other size `N`, will result in driver limiting the batches to either `N`, or `ceil(target_total_number_of_pool_connections / 2)`, whichever is smaller. The main motivation for this change is to allow for leveraging TLSv1.3 stateless session resumption using session tickets. Most of the time driver ends up without usable tickets for connecting, mainly due to the way the management of those tickets is done by Java itself. By running connection in batches it allows the driver to obtain some tickets for the next batches, allowing at least some of the connections to avoid negotiation. This feature can also be used outside of this situation. Just throttling should also bring some relief in case of mass reconnections.
Modifies current implementation of `addMissingChannels` in `ChannelPool` to make use of the newly added option. Default behavior remains unchanged.
Adds a method to get contact points with default shard aware port from `ccmBridge`.
…a refresh Instead of carrying contact point nodes through to InitialNodeListRefresh and matching them by endpoint, the control connection now resolves the connected node's full identity (hostId, datacenter, rack, etc.) by querying system.local immediately after establishing the channel. The resolved node is registered into metadata via MetadataManager.registerNode before the initial node list refresh runs, so the refresh can find and reuse it by hostId — preserving connection state. Key changes: - TopologyMonitor: rename getChannelEndpoint to getChannelNodeInfo, returning full NodeInfo instead of just an EndPoint - ControlConnection: add controlNode() accessor; resolve contact point nodes via system.local and register them into metadata; track currentControlNode/pendingControlNode for event matching - MetadataManager: add registerNode() to atomically insert a node into metadata by hostId; remove contact points parameter from InitialNodeListRefresh - InitialNodeListRefresh: match discovered nodes against existing metadata entries by hostId instead of matching contact points by endpoint - Load balancing helpers: infer local DC from control connection (controlNode hostId or channel endpoint) instead of contact points; replace checkLocalDatacenterCompatibility with a warning when the configured DC doesn't match any node
Replace fixed Thread.sleep calls with Awaitility's polling-based waiting in MetricsITBase, DefaultMetadataTabletMapIT, and MockResolverIT. This eliminates wasted wait time by polling for the expected condition instead of sleeping for a fixed duration. DriverBlockHoundIntegrationIT is left unchanged as its sleep is intentional for BlockHound testing.
- Default advanced.resolve-contact-points to false so contact points are stored as unresolved DNS names, enabling proper re-resolution on reconnection. - Update OptionsMap default for RESOLVE_CONTACT_POINTS to match. - Append contact points to the end of the control reconnection query plan when CONTROL_CONNECTION_RECONNECT_CONTACT_POINTS is enabled, instead of using them only as a fallback when the LBP query plan is empty. This ensures the driver can fall back to contact points within a single reconnection attempt if all LBP-suggested nodes fail.
Remove shared Copilot/AI config files from .github and add them to .gitignore so each contributor can manage their own AI tool context without affecting others.
…R-367) Replace SELECT * with explicit column projections in system.local and system.peers/peers_v2 queries issued by DefaultTopologyMonitor. The column list is learned dynamically at runtime: the first SELECT * response populates a volatile cache per table; all subsequent queries use the cached column names to build projected SELECTs. The caches are reset to null on control-connection reconnect, which causes the next call to re-issue SELECT * and re-learn whatever columns are available. This avoids sending unnecessary data (e.g. large tokens columns) on every topology refresh while remaining compatible with any server schema version without a hardcoded column list. Implementation details: - AdminResult.getColumnNames(): new method returning the set of column names from the result metadata, used to populate the caches. - DefaultTopologyMonitor: three volatile caches (localColumns, peersColumns, peersV2Columns), buildQuery() helpers, and resetColumnCaches() called by ControlConnection.onSuccessfulReconnect. - Cache-population sites guard against caching an empty column set (e.g. when the server returns no rows) so the next call retries with SELECT * instead of projecting zero columns. - Narrow single-node refreshNode() WHERE-clause queries always use SELECT * because projecting a one-row result gives negligible benefit and the fixed form is required by test infrastructure (Simulacron primes only SELECT * for that query shape). Tests: - DefaultTopologyMonitorTest: 30 unit tests (2 new warm-cache/reset tests, 1 new empty-column-set guard test). - AdminResultTest: 3 new tests for getColumnNames(). - ProtocolVersionMixedClusterIT: updated to expect projected query on the second system.local call after the cache is warmed. - PeersV2NodeRefreshIT: updated hasNodeRefreshQuery() to match on the stable WHERE-clause suffix rather than the SELECT * literal.
Replace all third-party action version tags (e.g. @v5) with immutable commit SHAs to reduce supply chain attack surface. Version tags are mutable and can be redirected to malicious code; SHAs are permanent. The pinned versions are: actions/checkout v5.0.1 93cb6efe18208431cddfb8368fd83d5badbf9bfd actions/setup-java v5.2.0 be666c2fcd27ec809703dec50e508c2fdc7f6654 actions/setup-python v6.2.0 a309ff8b426b58ec0e2a45f0f869d46889d02405 actions/cache (restore/save)v4.3.0 0057852bfaa89a56745cba8c7296529d2fc39830 actions/upload-artifact v4.6.2 ea165f8d65b6e75b540449e92b4886f43607fa02 astral-sh/setup-uv v6.8.0 d0cc045d04ccac9d8b7881df0226f9e82c39688e mikepenz/action-junit-report v5.6.2 3585e9575db828022551b4231f165eb59a0e74e3 scylladb/github-automation main 7b9848eb304fd3af1e757fe3c3c1ed497515f0fc Also adds a section to CONTRIBUTING.md explaining how to safely update pinned actions in the future (find SHA for tag, verify no impostor commit, update workflow files and repo settings allowlist). Closes: DRIVER-582
…on tests ScyllaDB PR scylladb/scylladb#25342 changed ks_prop_defs::as_ks_metadata() so that tablets are now enabled by default for all replication strategies. SimpleStrategy does not support tablets and throws: InvalidConfigurationInQueryException: SimpleStrategy doesn't support tablet replication Replace all SimpleStrategy keyspace creation in integration tests with NetworkTopologyStrategy (datacenter1), which supports tablets. Files changed: - SessionUtils.createKeyspace(): central keyspace creator used by SessionRule (fixes the majority of test failures via cascade) - SchemaChangesIT: 3 CREATE + 1 ALTER CQL strings + updated assertion (NTS replication map has class + datacenter1 instead of class + replication_factor) - TokenITBase: 2 CREATE KEYSPACE (RF=1 and RF=2) - SimpleStatementCcmIT: 1 CREATE KEYSPACE - LWTLoadBalancingIT: 1 CREATE KEYSPACE (RF=3) - DefaultKeyspaceIT: 1 CREATE KEYSPACE (mapper test) - QueryKeyspaceAndTableIT: 1 CREATE KEYSPACE (mapper test) - MailboxServiceImpl: 1 CREATE KEYSPACE (osgi test)
…tics (DRIVER-540) Add NodeDiagnostics public inner class to DriverTimeoutException with fields for in-flight counts and pool capacity, and generate a diagnostic suffix in the exception message at timeout time. Refactor all four request-handler timeout paths (CqlRequestHandler, CqlPrepareHandler, GraphRequestHandler, ContinuousRequestHandlerBase) to build List<NodeDiagnostics> instead of a raw message string. Update IT assertions that matched exact message strings to use hasMessageStartingWith() to accommodate the new suffix.
Driver did not consider SERIAL SELECT as LWT and therefore routed them as regular queries causing LWT congestion. Fix is to consider consistency when RequestRoutingMethod is calculated.
… pool size (DRIVER-540) Add four additional fields to DriverTimeoutException.NodeDiagnostics captured at timeout time: - nodeState: UP/DOWN/FORCED_DOWN/UNKNOWN — immediately explains timeouts to downed nodes - nodeDistance: LOCAL/REMOTE/IGNORED — contextualizes latency expectations - datacenter: node DC — helps diagnose cross-DC routing issues - poolSize: active connection count — reveals degraded pools (fewer connections than expected) All four are available from Node and ChannelPool already in scope at each buildNodeDiagnostics() call site. No new infrastructure required. Updated toString() example: /10.0.0.1:9042 [state: UP, distance: LOCAL, dc: dc1, channel in-flight: 5, pool size: 3, pool in-flight: 12, pool available ids: 988, pool orphaned ids: 2]
scylla-4.19.0.x was cut at 4.19.0.1 and never moved, so the docs site documents a release eight patches old. Merge the latest 4.19.0 release with its next-development pom bump, so the branch can be released from. Conflicts resolved in favour of the tag, except docs/_utils/javadoc.sh, taken whole from scylla-4.x (scylladb#1118): the tag's copy reads target/site, but plugin 3.12.0 writes target/reports, so it would publish an empty api/. The branch's eval_rst toctrees are kept for recommonmark. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
A push to this branch runs its own copy of docs-pages.yml, which rebuilds and deploys the whole site. The copy inherited from 4.19.0.9 installs JDK 11 only and has no javadoc guard, so it would publish every JDK 8 version without its api/. Use scylla-4.x's copy. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
The full-reactor install races: examples names mapper-processor as an annotation processor path, not a dependency, so with -T 1C it can compile before mapper-processor is installed. On a -SNAPSHOT version nothing on Central fills the gap, the install fails, and the version publishes without api/. Reproduced on 4.19.0.10-SNAPSHOT with 22 threads. Install core, query-builder and mapper-runtime with -am. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> (cherry picked from commit 8d4ce98)
|
Important Review skippedToo many files! This PR contains 281 files, which is 181 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (281)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
Author
|
CI: the three DiagnosisScylla LATEST now resolves to
|
nikagra
marked this pull request as ready for review
September 25, 2026 09:18
|
Closing because this branch sync was completed manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scylla-4.19.0.xwas cut at 4.19.0.1 and never moved, so/stable/documents a release eight patches old. This makes the branch 4.19.0.9 plus docs fixes, rooted at the release so it can be released from.Merge with "Create a merge commit". A rebase or squash merge replays the 239 release commits and the branch stops descending from the tag.
9149592b46(4.19.0.9 + bump to 4.19.0.10-SNAPSHOT); conflicts taken from the tag, exceptjavadoc.sh, taken fromscylla-4.x(the tag's copy readstarget/site, plugin 3.12.0 writestarget/reports)eval_rsttoctrees, for recommonmarkscylla-4.x'sdocs-pages.yml: a push here runs this branch's own copy, which would deploy the site without the JDK 11 versions'api/Verified:
git diff 9149592b46is exactly those 14 files (the install fix touches the samejavadoc.sh); a local four-version multiversion build published 1162 javadoc files for this version and the guard passed. No docs CI runs for PRs into this branch.CI:
security/snykfails; not investigated. This PR changes no dependency declarations beyond what the 4.19.0.9 release already ships.Refs #1133
Jira: DRIVER-1108
🤖 Generated with Claude Code