Repository navigation
docs: add the connectivity section to the 4.18.1 manual - #1144
Merged
Merged
Conversation
A push to this branch runs its own copy of the docs publish workflow, which rebuilds and deploys the whole site. This copy installs JDK 8 only and has no javadoc guard, so it would publish every JDK 11 version without its api/. Replace it with scylla-4.x's docs-pages.yml. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
nikagra
force-pushed
the
connectivity-4181
branch
from
September 25, 2026 11:37
c2c6b6a to
c404d7d
Compare
nikagra
force-pushed
the
connectivity-4181
branch
from
September 25, 2026 12:32
c404d7d to
1676310
Compare
This was referenced Sep 25, 2026
nikagra
force-pushed
the
connectivity-4181
branch
from
September 25, 2026 13:16
1676310 to
6073116
Compare
This was referenced Sep 28, 2026
Port the connectivity section from scylla-4.x (scylladb#1130) so the 4.18.1.x docs answer the same network questions: an index, and a page for VPC peering, Transit Gateway and direct connections. Client routes do not exist before 4.19.0.7, so their page says so, carries the search aliases, and explains why an address translator is no substitute. Hostname-expansion and subnet-proxy text is dropped; neither exists in this version. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
nikagra
force-pushed
the
connectivity-4181
branch
from
October 1, 2026 17:57
c7cde19 to
492ed67
Compare
nikagra
marked this pull request as ready for review
October 1, 2026 18:05
The example connected to 9142, the TLS port, without enabling TLS, and the truststore setup came only afterwards as a HOCON block, so the code copied as shown fails to connect. Configure the engine factory in the builder and keep the HOCON block as the application.conf alternative. Say the TLS port is why the example needs TLS, and quote the truststore password, which HOCON cuts at #. Note the NullPointerException warning 4.18.1 logs on close when there is no keystore, and say that a createUnresolved contact point is looked up again on every connect rather than only at startup. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
nikagra
force-pushed
the
connectivity-4181
branch
from
October 1, 2026 18:09
993a109 to
9ae8812
Compare
dkropachev
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #1141 (stacked; review the last two commits)
Blocks: nothing
If #1141 is squash-merged, rebase this onto the new base before merging.
The 4.18.1 manual has no page answering how to connect to a cluster over VPC peering, Transit Gateway or the public internet, or whether PrivateLink works in this version. This ports #1130's Connectivity section, fitted to what 4.18.1 actually does.
manual/core/connectivity/: index, VPC peering / Transit Gateway / direct connection page, and a client routes page saying the feature needs 4.19.0.7+; a translator for a proxy must give each node its own address and portmanual/core/README.mdwithConfigLoader), with the truststore import first; same change as docs: enable TLS in the ScyllaDB Cloud connection example #1163 (scylla-4.x) and docs: add the connectivity section to the 4.19.0 manual #1143, from dkropachev's review there. Checked against driver-core 4.18.1.0: the example's loader yieldsDefaultSslEngineFactory, and the build shows the same 111 warnings as without the changeVerified with a clean
make test: the warning set is identical to the base commit's (111, all pre-existing "not in any toctree" kinds), and the three pages render with the new text.CI: every
tests@v1job fails at Set up job because this branch's own[email protected]uses unpinned actions, which the org now rejects. Pre-existing; any push to the branch hits it.Refs: #1119, https://scylladb.atlassian.net/browse/DRIVER-1042
🤖 Generated with Claude Code