Repository navigation
docs: enable TLS in the ScyllaDB Cloud connection example - #1163
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The example connected to 9142, the TLS port, without enabling TLS, and the truststore setup came only afterwards as a HOCON block, so the code copied as shown fails to connect. Configure the engine factory in the builder and keep the HOCON block as the application.conf alternative. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
nikagra
force-pushed
the
docs-vpc-tls-example
branch
from
September 30, 2026 13:32
8b14b98 to
a8f9041
Compare
This was referenced Sep 30, 2026
nikagra
marked this pull request as ready for review
September 30, 2026 15:41
dkropachev
approved these changes
Oct 1, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: nothing
Blocks: nothing; reaches
/stable/on the next fast-forward ofscylla-4.19.2.x. #1143 (4.19.0.x) and #1144 (4.18.1.x) get the same changeThe VPC-peering page's Java example connects to 9142, the TLS port, but enables no TLS; the truststore setup comes only afterwards, as a HOCON block. Copied as shown, the example fails during connection setup. dkropachev found this on #1143; the same example is on
scylla-4.x.DefaultSslEngineFactoryand the truststore in the builder, withDriverConfigLoader.programmaticBuilder(), using the same three options as the HOCON block-storepassto it, so its password matches the one the example uses (CodeRabbit on docs: add the connectivity section to the 4.19.0 manual #1143); keep the HOCON block as theapplication.confalternativeVerified:
DefaultDriverContextfrom the documented loader with a real truststore: every version yieldsDefaultSslEngineFactory, while the old example's default config yields no SSL engine factory. The documentedkeytoolcommand, run as written, produces a truststore the loader opensmake -C docs test(-W) succeedsNot covered: a handshake against a real ScyllaDB Cloud cluster.
🤖 Generated with Claude Code