Repository navigation
docs: fix ScyllaDB Cloud TLS and client routes details - #1151
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nikagra
marked this pull request as ready for review
September 25, 2026 13:10
scylladb#1130 shipped a TLS sample on Cloud's plaintext port with a CA that does not apply, the internode column in the system.local query, client routes pointers that ignore single-hostname proxies, and the wrong thread for route DNS lookups. Fix them here so the per-version backports copy one wording. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
nikagra
force-pushed
the
connectivity-fixes
branch
from
September 25, 2026 13:16
280e1be to
f8af702
Compare
dkropachev
approved these changes
Sep 25, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: nothing (independent of #1139; they merge in either order)
Blocks: nothing
#1130's connectivity pages have mistakes that block a ScyllaDB Cloud connection: the TLS sample uses the plaintext port and trusts a public CA, and the client routes pointers send single-hostname proxies to the wrong answer. #1143 and #1149 already carry these fixes (#1144 and #1145 some of them), so this puts them on
scylla-4.xand every copy uses the same wording.rpc_address; the quick overview links to the page's own "not reachable" sectionFixedHostNameAddressTranslator, whose snippet now nestsadvertised-hostnamewhere the translator reads it, with the caveat that it keeps each node's port, so without a port per node the proxy picks the nodenetworkaddress.cache.ttlis read oncecreateUnresolved, and the upgrade guide's HOCON example sets contact pointsVerified with
cd docs && make test(exit 0, no warnings) and by grepping the built HTML for the new anchors. Not covered: the multiversion site build.Refs #1119
Jira: DRIVER-1042
🤖 Generated with Claude Code