Skip to content

docs: build scylla-3.11.5.x with recommonmark again - #1153

Closed
nikagra wants to merge 2 commits into
scylladb:scylla-3.11.5.xfrom
nikagra:fix-3115-docs-build
Closed

nikagra wants to merge 2 commits into
scylladb:scylla-3.11.5.xfrom
nikagra:fix-3115-docs-build

Conversation

@nikagra

@nikagra nikagra commented Sep 28, 2026

Copy link
Copy Markdown

Depends on: nothing
Blocks: #1145

This fixes the live /scylla-3.11.5.x/. The branch was reset to the scylla-3.x tip, which writes its toctrees as {eval-rst}, but #1146 builds this version with recommonmark, which renders them as code blocks. So the published 3.x manual has lost its navigation.

  • re-apply c3f946458e "Switch back to eval_rst" (7 files, cherry-picked unchanged)
  • replace this branch's docs-pages.yaml with scylla-4.x's docs-pages.yml: a push here runs the branch's own copy, which rebuilds the whole site with JDK 8 only and no javadoc guard, so the next docs change would drop /stable/api/

The branch now carries one commit scylla-3.x does not, so it can no longer be fast-forwarded to it.

Verified: grep '{eval-rst}' is empty; a local four-version multiversion build with scylla-4.x's current conf.py renders this version's navigation (no code-block toctrees) with a 678-file api/, and the javadoc guard passes. No docs CI runs for PRs into this branch.

Refs #1134

🤖 Generated with Claude Code

Bouncheck and others added 2 commits September 28, 2026 14:06
Replaces occurences `{eval-rst}` occurences with `eval_rst` across
manuals. The former is used with myst parser the latter with recommonmark.
Myst parser version is currently worse because it does not link other pages
referenced in text correctly. It treats them as anchors on the same page.

(cherry picked from commit c3f9464)
A push to this branch runs its own copy of the docs publish workflow,
which rebuilds and deploys the whole site. This copy installs JDK 8
only and has no javadoc guard, so it would publish every JDK 11 version
without its api/. Replace it with scylla-4.x's docs-pages.yml.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: 9755fad2-93c1-4ab6-b9b4-f69f7036fe92

📥 Commits

Reviewing files that changed from the base of the PR and between 5a2f793 and e6d1a8e.

📒 Files selected for processing (9)
  • .github/workflows/docs-pages.yaml
  • .github/workflows/docs-pages.yml
  • faq/osgi/README.md
  • manual/README.md
  • manual/custom_codecs/extras/README.md
  • manual/object_mapper/README.md
  • manual/statements/README.md
  • upgrade_guide/README.md
  • upgrade_guide/migrating_from_astyanax/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nikagra

nikagra commented Sep 28, 2026

Copy link
Copy Markdown
Author

Superseded: scylla-3.11.5.x now only fast-forwards from scylla-3.x. #1155 carries this PR's workflow commit to scylla-3.x. #1156 replaces the eval_rst swap by building scylla-3.11.5.x with MyST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants