Repository navigation
Conversation
Contributor
|
Super awesome! I just approved the CI for this and thanks so much for this PR. |
Author
|
Sure! Some message also defines |
Contributor
|
Thanks for this PR ser (and sry for the delay)! There were a few other features added to the x/dex module since last year and the checks have been added to |
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Used in unit tests in sei-chain ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Used in unit tests in sei-chain ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidateBasicofsdk.Msgallows performing static checks for an sdk message.These checks are performed before the message is broadcast to the network, therefore it is more optimized to have these checks in
ValidateBasicrather that in the message handler to save gas for txs bound to fail.This PR adds some more checks in message validate basic like contract address check or coins validity checks