Repository navigation
feat: Move commonjs exports down for worklet files - #6316
Merged
Merged
Conversation
tjzel
marked this pull request as ready for review
July 23, 2024 09:56
tomekzaw
approved these changes
Jul 23, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
…6316) ## Summary Since Reanimated Babel Plugin breaks hoisting and [newer Typescript hoists CommonJS exports by default](microsoft/TypeScript#57669) we sometimes need to dehoist those exports. ## Test plan - [x] Add unit test suite. - [x] Runtime tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since Reanimated Babel Plugin breaks hoisting and newer Typescript hoists CommonJS exports by default we sometimes need to dehoist those exports.
Test plan