Repository navigation
solver: match glibc constraints by hash - #51559
Merged
alalazo merged 4 commits intoNov 18, 2025
Merged
Conversation
alalazo
changed the title
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
force-pushed
the
bugfix/solver-same-compiler-different-libc
branch
from
November 14, 2025 12:41
c1a0791 to
9ec3ed4
Compare
Member
Author
|
Benchmarked against:
radiuss.develop.csv 
|
alalazo
marked this pull request as ready for review
November 14, 2025 17:44
haampie
reviewed
Nov 17, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
approved these changes
Nov 18, 2025
alalazo
added
v1.0.3
psakievich
pushed a commit
to psakievich/spack
that referenced
this pull request
Dec 1, 2025
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
When we added compiler runtimes, we matched compilers by `<compiler.name>@<compiler.versions>` due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way. This should solve issues where e.g. two gcc at the same version inject different libcs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
Member
|
This PR does not apply cleanly to releases/v1.0 and will be dropped from v1.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51556
When we added compiler runtimes, we matched compilers by
<compiler.name>@<compiler.versions>due to how externals were modeled at the time. Now that externals are concrete specs, we can match by hash and enforce constraints in a more precise way.This should solve issues where e.g. two gcc at the same version inject different libcs.