Repository navigation
performance bugfix: only expose buildable oses to solver - #52604
Merged
Merged
Conversation
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
tgamblin
approved these changes
Jun 24, 2026
Member
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, ruff-format, ruff-check, mypy
==> Running import checks
import checks were clean
==> Running ruff-format checks
ruff-format checks were clean
==> Running ruff-check checks
F841 Local variable `default_macos` is assigned to but never used
--> lib/spack/spack/test/architecture.py:140:5
|
138 | def test_instantiate_non_default_macos(mock_packages):
139 | darwin = spack.platforms.Darwin()
140 | default_macos = darwin.operating_system("default_os")
| ^^^^^^^^^^^^^
141 |
142 | for name, macos in darwin.operating_sys.items():
|
help: Remove assignment to unused variable `default_macos`
ruff-check found errors
==> Running mypy checks
Success: no issues found in 639 source files
mypy checks were clean
I've updated the branch with style fixes. |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
becker33
force-pushed
the
bugfix/performance-regression-macos
branch
from
June 24, 2026 12:45
e778b3c to
0c4bde3
Compare
Signed-off-by: Gregory Becker <[email protected]>
tgamblin
approved these changes
Jun 25, 2026
haampie
pushed a commit
that referenced
this pull request
Jul 6, 2026
Fixes #52602 Macos needs to know about older operating systems, to reconstruct specs from them, but it doesn't need to expose them to the solver unless they are coming in from a reused spec. Generalized to a `buildable_oses` method on the `Platform` class. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
becker33
added a commit
that referenced
this pull request
Jul 6, 2026
Fixes #52602 Macos needs to know about older operating systems, to reconstruct specs from them, but it doesn't need to expose them to the solver unless they are coming in from a reused spec. Generalized to a `buildable_oses` method on the `Platform` class. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
Aiden2244
pushed a commit
to Aiden2244/spack
that referenced
this pull request
Jul 20, 2026
Fixes spack#52602 Macos needs to know about older operating systems, to reconstruct specs from them, but it doesn't need to expose them to the solver unless they are coming in from a reused spec. Generalized to a `buildable_oses` method on the `Platform` class. --------- Signed-off-by: Gregory Becker <[email protected]> Co-authored-by: becker33 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52602
Macos needs to know about older operating systems, to reconstruct specs from them, but it doesn't need to expose them to the solver unless they are coming in from a reused spec.
Generalized to a
buildable_osesmethod on thePlatformclass.@alecbcs