Repository navigation
Replace 1/x with inv(x) - issue #595 - #626
Conversation
|
Can one of the admins verify this patch? |
bob-carpenter
left a comment
bob-carpenter
left a comment
There was a problem hiding this comment.
Thanks. This will speed up forward mode and it shouldn't slow down reverse mode. I think it's a bit clearer, too.
|
Hey, this is causing http://d1m1s1b1.stat.columbia.edu:8080/job/Math%20-%20Tests%20-%20Header/249/ |
|
Sorry about that, looks like I missed the "inv" library for a couple of the rngs, and then ran test-headers on the wrong branch (clear signs of a long week). Everything's now passing after including the libraries, I'll make a new pr with the fixed changes. |
|
@seantalts --- thanks for reverting. I didn't realize it didn't pass tests. Is there something we need to do to run tests again? |
|
When you see this, one of the admins has to say "Jenkins, ok to test" I'm working on overhauling / modernizing our Jenkins jobs to use pipelines and this workflow might change... I would also be okay with allowing all pull requests to be built unless we've seen abuse from that in the past / until we see abuse from it in the future. |
4 participants
Submission Checklist
./runTests.py test/unitmake cpplintSummary:
Replace all instances of 1/x in prim/scal/prob with inv(x). See #595
Replace inv(x*x) with inv_square(x)
Intended Effect:
Make code more efficient/consistent.
How to Verify:
Side Effects:
None (hopefully).
Documentation:
None.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: