Skip to content

Feature/add bessel and pochhammer - #98

Merged
syclik merged 26 commits into
developfrom
feature/add_bessel_and_pochhammer
Jun 26, 2013
Merged

syclik merged 26 commits into
developfrom
feature/add_bessel_and_pochhammer

Conversation

@PeterLi2016

Copy link
Copy Markdown
Contributor

Added Bessel functions of first and second kind, modified Bessel functions of first and second kind, and rising and falling factorial to math lib and fwd/rev auto-diff.

@stan-buildbot

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set up a variable using any constructor, like:

fvar<double> a(4.0,1.0);

@bob-carpenter

Copy link
Copy Markdown
Member

For the Bessel functions, you should either restrict the order argument to integers or test the differentiation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should either restrict the order v to an int, or provide all the signatures and test the derivatives of the order.

@PeterLi2016

Copy link
Copy Markdown
Contributor Author

Everything should be tested (in math lib, fvar, and var) for the Bessel functions and modified Bessel functions of first and second kind, falling factorial, rising factorial, log falling factorial, log rising factorial and in the manual.

…sing factorial (and logs of them), bessel funciton of first/second kind, modified bessel function of first/second kind
@PeterLi2016

Copy link
Copy Markdown
Contributor Author

This solves issue #96.

@syclik

syclik commented Jun 25, 2013

Copy link
Copy Markdown
Member

Jenkins, ok to test.

@stan-buildbot

Copy link
Copy Markdown
Contributor

Test PASSed.
Refer to this link for build results: http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Github%20Pull%20Requests/94/

@syclik

syclik commented Jun 26, 2013

Copy link
Copy Markdown
Member

Looks good to me. There are tests and doc for the new functions. Tests pass.

syclik added a commit that referenced this pull request Jun 26, 2013
@syclik
syclik merged commit 9ef10cd into develop Jun 26, 2013
@syclik
syclik deleted the feature/add_bessel_and_pochhammer branch June 26, 2013 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants