network: Allow to specify multiple IPv6Token for SLAAC by ssahani · Pull Request #14415 · systemd/systemd

ssahani · 2019-12-21T19:32:44Z

Provide names to choose between different auto-generation types:
2.1 "eui64" for EUI-64 of RFC 4291
2.2 "prefixstable" for RFC 7217

[Match]
Name=veth99

[Network]
DHCP=no
IPv6AcceptRA=yes
IPv6Token=prefixstable:2001:888:0db8:1::/64

closes #6889

poettering · 2019-12-23T18:12:22Z

looks pretty good to me from a superficial review. I'll leave it to @yuwata to merge though.

ssahani · 2020-01-08T16:57:15Z

Ping @yuwata

ssahani · 2020-01-09T12:24:32Z

Updated thanks for the review @poettering @yuwata

yuwata · 2020-01-09T12:34:05Z

LGTM. I will test this later.

yuwata

Sorry, one more round.

ssahani · 2020-01-13T05:02:16Z

updated thanks @yuwata

yuwata · 2020-01-13T05:04:00Z

LGTM. I will test this later.

yuwata · 2020-01-26T12:34:06Z

@ssahani Updated. Fixed several errors in ipv6_makestableprivate(), and added a test case. PTAL.

(And sorry for late to test this.)

ssahani · 2020-01-26T12:44:29Z

I am not sure not able to compile from couple of days

ninja -C build
ninja: Entering directory `build'
[29/101] Generating systemd_boot.so with a custom command.
FAILED: src/boot/efi/systemd_boot.so 
/usr/bin/ld -o src/boot/efi/systemd_boot.so -T /usr/lib64/gnuefi/elf_x64_efi.lds -shared -Bsymbolic -nostdlib -znocombreloc -L /usr/lib64 /usr/lib64/gnuefi/crt0-efi-x64.o src/boot/efi/disk.c.o src/boot/efi/graphics.c.o src/boot/efi/measure.c.o src/boot/efi/pe.c.o src/boot/efi/util.c.o src/boot/efi/boot.c.o src/boot/efi/console.c.o src/boot/efi/crc32.c.o src/boot/efi/random-seed.c.o src/boot/efi/sha256.c.o src/boot/efi/shim.c.o -lefi -lgnuefi /usr/lib/gcc/x86_64-redhat-linux/10/libgcc.a
/usr/bin/ld: src/boot/efi/graphics.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/pe.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/util.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/boot.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/console.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/random-seed.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of  loader_guid src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
/usr/bin/ld: src/boot/efi/shim.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: multiple definition of `loader_guid'; src/boot/efi/disk.c.o:/home/sus/tt/systemd/build/../src/boot/efi/util.h:58: first defined here
[31/101] Generating splash.c.o with a custom command.
ninja: build stopped: subcommand failed.
make: *** [Makefile:2: all] Error 1

ssahani · 2020-01-26T14:37:18Z

Lgtm

yuwata · 2020-01-26T17:12:22Z

This needs #14670. I will force-push this after #14670 is merged to restart the CIs.

yuwata · 2020-01-28T15:36:28Z

hmmmm??

Jan 28 16:30:10 arch.localdomain systemd-networkd[34251]: Failed to get machine id: Operation not supported
Jan 28 16:30:10 arch.localdomain systemd-networkd[34251]: veth99: Falied to generate prefix stable address: Operation not supported

yuwata · 2020-01-28T15:39:39Z

Ah,

RestrictAddressFamilies=AF_UNIX AF_NETLINK AF_INET AF_INET6 AF_PACKET

@mrc0mmand Is it possible to update the unit file systemd-networkd.service? Please see #14670.

unit file in case a PR introduces changes in them See: systemd/systemd#14415 (comment)

mrc0mmand · 2020-01-28T15:58:13Z

Ah,
RestrictAddressFamilies=AF_UNIX AF_NETLINK AF_INET AF_INET6 AF_PACKET
@mrc0mmand Is it possible to update the unit file systemd-networkd.service? Please see #14670.

Should be fixed by systemd/systemd-centos-ci@0a37f42. I re-triggered both failing jobs, but it may take a while, as there's already a queue of running jobs.

yuwata · 2020-01-28T16:04:15Z

@mrc0mmand Thanks!

yuwata · 2020-01-30T08:33:23Z

@poettering Thank you for the comments. Updated. PTAL.

yuwata · 2020-02-03T08:15:35Z

Rebased.

yuwata · 2020-02-03T14:45:26Z

@keszybz Could you review this? We already addressed all suggestions by @poettering.

yuwata · 2020-02-05T06:26:01Z

Rebased again. @keszybz PTAL.

keszybz

Looks pretty OK in general...

Provide names to choose between different auto-generation types: 2.1 "eui64" for EUI-64 of RFC 4291 2.2 "prefixstable" for RFC 7217 ``` [Match] Name=veth99 [Network] DHCP=no IPv6AcceptRA=yes IPv6Token=prefixstable:2001:888:0db8:1:: ```

yuwata · 2020-02-05T08:46:49Z

@keszybz Thank you for the review. All points are addressed. PTAL.

keszybz · 2020-02-05T08:56:00Z

Thanks, LGTM.

kpfleming · 2020-02-05T16:33:02Z

-            the token is only ever used for SLAAC, and not for DHCPv6 addresses, even
-            in the case DHCP is requested by router advertisement. By default, the
-            token is autogenerated.</para>
+            <para>Specifies an optional address generation mechanism and an optional address prefix. If


This documentation is somewhat confusing to me; when eui64 mode is used, the supplied address is not a prefix, it's a suffix. Unless someone is already working on it, I'd be happy to send a PR to improve the documentation.

As I read through the code my confusion is growing... as this 'eui64' mode replaces the existing unnamed 'static' mode where the user supplies the token (which may or may not have been generated using the EUI-64 mechanism). This is even evident in the eui64 test case, where a static token is supplied which is almost certainly not a valid EUI-64 Interface Identifer, but it is treated as such in the code.

Unless I'm mistaken, there should be three modes:

static - user supplies the lowest 64 bits of address, generated in any fashion they wish

eui64 - user does not (and cannot) supply an address but explicitly requests that an EUI-64 IiD be generated

prefixstable - user supplies a prefix (of varying length) and an RFC7217 IID is generated

I know I'm coming into this discussion quite late and the PR has already been merged, but I'm currently a happy user of the 'static' mode and I wouldn't want anyone to use the 'eui64' label for that mode, or for any diagnostic or error messages to refer to 'eui64' mode when I didn't request it.

I will take a look later.

poettering added the network label Dec 23, 2019

yuwata reviewed Jan 9, 2020

View reviewed changes

Comment thread src/network/networkd-ndisc.c Outdated

yuwata requested changes Jan 9, 2020

View reviewed changes

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

yuwata added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 9, 2020

ssahani force-pushed the prefixstable-rfc-7217-new branch from 3a964d5 to f2ebf4d Compare January 9, 2020 12:24

yuwata reviewed Jan 10, 2020

View reviewed changes

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

ssahani force-pushed the prefixstable-rfc-7217-new branch from f2ebf4d to 4a85ac8 Compare January 13, 2020 05:01

yuwata force-pushed the prefixstable-rfc-7217-new branch from 4a85ac8 to 6e8c031 Compare January 26, 2020 12:19

yuwata removed the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 26, 2020

ssahani commented Jan 26, 2020

View reviewed changes

Comment thread test/test-network/systemd-networkd-tests.py Outdated

yuwata force-pushed the prefixstable-rfc-7217-new branch from 6e8c031 to cd1d682 Compare January 26, 2020 14:13

yuwata added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 26, 2020

yuwata force-pushed the prefixstable-rfc-7217-new branch from cd1d682 to 1a2aa72 Compare January 28, 2020 14:36

mrc0mmand added a commit to systemd/systemd-centos-ci that referenced this pull request Jan 28, 2020

vagrant: manually install upstream systemd-networkd* service...

0a37f42

unit file in case a PR introduces changes in them See: systemd/systemd#14415 (comment)

poettering requested changes Jan 28, 2020

View reviewed changes

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

Comment thread src/network/networkd-ndisc.c Outdated

poettering removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 28, 2020

poettering added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 28, 2020

yuwata force-pushed the prefixstable-rfc-7217-new branch from 1a2aa72 to 3a23d22 Compare January 30, 2020 08:31

yuwata removed the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 30, 2020

yuwata force-pushed the prefixstable-rfc-7217-new branch from 3a23d22 to 47723b0 Compare February 3, 2020 08:00

yuwata added the needs-rebase label Feb 5, 2020

yuwata added this to the v245 milestone Feb 5, 2020

yuwata force-pushed the prefixstable-rfc-7217-new branch from 47723b0 to 8607ad6 Compare February 5, 2020 06:24

yuwata removed the needs-rebase label Feb 5, 2020

keszybz requested changes Feb 5, 2020

View reviewed changes

ssahani and others added 2 commits February 5, 2020 17:44

test-network: add tests for IPv6Token=

87bbebe

yuwata force-pushed the prefixstable-rfc-7217-new branch from 8607ad6 to 87bbebe Compare February 5, 2020 08:45

keszybz added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Feb 5, 2020

keszybz merged commit 5bbcff2 into systemd:master Feb 5, 2020

kpfleming reviewed Feb 5, 2020

View reviewed changes

yuwata removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Feb 6, 2020

ssahani deleted the prefixstable-rfc-7217-new branch February 7, 2020 09:04

yuwata mentioned this pull request Feb 10, 2020

Support multiple IPv6Token 'static' addreses on an interface #14833

Merged

ssahani mentioned this pull request Feb 12, 2020

[networkd] keeps old interface id when global prefix changes #10499

Open

slyon mentioned this pull request Apr 6, 2020

Add IPv6 addr-gen-mode field for NM backend canonical/netplan#126

Merged

3 of 4 tasks

Conversation

ssahani commented Dec 21, 2019

Uh oh!

poettering commented Dec 23, 2019

Uh oh!

ssahani commented Jan 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssahani commented Jan 9, 2020

Uh oh!

yuwata commented Jan 9, 2020

Uh oh!

yuwata left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssahani commented Jan 13, 2020

Uh oh!

yuwata commented Jan 13, 2020

Uh oh!

yuwata commented Jan 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ssahani commented Jan 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ssahani commented Jan 26, 2020

Uh oh!

yuwata commented Jan 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuwata commented Jan 28, 2020

Uh oh!

yuwata commented Jan 28, 2020

Uh oh!

mrc0mmand commented Jan 28, 2020

Uh oh!

yuwata commented Jan 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuwata commented Jan 30, 2020

Uh oh!

yuwata commented Feb 3, 2020

Uh oh!

yuwata commented Feb 3, 2020

Uh oh!

yuwata commented Feb 5, 2020

Uh oh!

keszybz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuwata commented Feb 5, 2020

Uh oh!

keszybz commented Feb 5, 2020

Uh oh!

kpfleming Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

keszybz Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

kpfleming Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

keszybz Feb 6, 2020

yuwata commented Jan 26, 2020 •

edited

Loading

ssahani commented Jan 26, 2020 •

edited

Loading

yuwata commented Jan 26, 2020 •

edited

Loading