Changes

On leader promotion the resolver framework listed ResolutionRequests with labels.Everything() and enqueued every one of them into every resolver's workqueue. The reconciler has no label guard of its own, so whichever resolver dequeued a request first ran Validate() and Resolve() on it regardless of its resolution.tekton.dev/type label. A request addressed to the http resolver could therefore be failed by the hub resolver with missing required hub resolver params: name, version, and since the request is then already done the correct resolver skips it.

The informer's event handler was already filtered by FilterResolutionRequestsBySelector. Only the promote path was not.

This passes the resolver's selector into LeaderAwareFuncs and lists with labels.SelectorFromSet, which applies the same AND-of-equality match the event handler uses. Both frameworks now read the selector once and share it between the two paths, so the two filters cannot drift apart. It also answers the TODO(sbwsg) that has sat on LeaderAwareFuncs since it was introduced ("Should we use the filter selector from above in the call to lister.List here?"), which is yes.

Compatibility

No exported signature changes. LeaderAwareFuncs keeps its original one-argument form and its labels.Everything() behaviour, now marked deprecated; the filtered listing is a new LeaderAwareFuncsWithSelector, which is what the two in-tree NewController funcs call. Out-of-tree resolvers keep compiling untouched.

One behaviour note: an empty label set now maps to labels.Nothing() rather than labels.Everything(), and both controllers validate the selector and panic on an invalid one.

Validation

• go build ./..., and every test binary under ./pkg/... and ./cmd/... compiles
• go test ./pkg/resolution/... ./pkg/remoteresolution/..., 21 packages pass
• pre-commit run on the changed files, including make test-unit over the whole repo
• The lint-go hook could not run because the install script rejects the golangci-lint v2.12.2 darwin/arm64 tarball on a checksum mismatch (c8debe3b... vs the expected a9c54498...). I installed that same pinned v2.12.2 with go install instead and ran it over both framework packages: 0 issues. Worth knowing if others hit it.
• The new TestLeaderAwareFuncsPromoteFiltersBySelector fails on all three table rows when the fix is reverted to labels.Everything(), with http-request and unlabeled-request leaking into the git resolver's queue.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Fixes #10484

Relates to #

Release Notes

Resolvers no longer fail ResolutionRequests belonging to a different resolver after a leader election or a resolver pod restart.