Repository navigation
Avoid division by zero on small windows - #214
Merged
Merged
Conversation
If the window is too small when the program starts, plotwidth stays at
zero. As soon as data arrives, handle_value() computes the appropriate
array index to store it, as
n = (n + 1) % plotwidth;
The division by zero makes the program crash with SIGFPE (Floating-point
exception).
Avoid the crash by initializing plotwidth to the smallest value it can
sensibly have.
edgar-bonet
requested review from
hartwork and
tenox7
and removed request for
hartwork
March 8, 2026 14:02
hartwork
approved these changes
Mar 8, 2026
hartwork
left a comment
hartwork
left a comment
Collaborator
There was a problem hiding this comment.
@edgar-bonet nice one! I confirm crasher COLUMNS=1 ./ttyplot <<<"1 2 3 4" fixed.
Owner
|
thank you! |
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
ttyplot 1.7.5 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Fix CI failure on maybe-uninitialized compiler warning by @edgar-bonet in tenox7/ttyplot#205 * CI: upgrade macOS runners by @edgar-bonet in tenox7/ttyplot#206 * Actions(deps): Bump codespell-project/actions-codespell from 2.1 to 2.2 by @dependabot[bot] in tenox7/ttyplot#208 * Avoid division by zero on small windows by @edgar-bonet in tenox7/ttyplot#214 * `ttyplot.c`: Fix in-code comment by @hartwork in tenox7/ttyplot#217 * Work on smaller windows with no clock display by @edgar-bonet in tenox7/ttyplot#215 **Full Changelog**: https://github.com/tenox7/ttyplot/compare/1.7.4...1.7.5</pre> <p>View the full release notes at <a href="https://github.com/tenox7/ttyplot/releases/tag/1.7.5">https://github.com/tenox7/ttyplot/releases/tag/1.7.5</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!12187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the window is too small when the program starts, ttyplot crashes on a division by zero (“Floating-point exception”). This is because
plotwidthnever gets set to a non-zero value, andhandle_value()performs a modulo operation withplotwidthas the denominator.This pull request fixes the crash by initializing
plotwidthwith the minimum value it can sensibly have.