modified convolution document by ZhengshengWei · Pull Request #14792 · tensorflow/tensorflow

ZhengshengWei · 2017-11-22T11:27:22Z

Document of _MaskedConv and MaskedConv2D could be revised too. Reasons are as follows.

tensorflow/tensorflow/contrib/model_pruning/python/layers/core_layers.py

Lines 164 to 171 in 5fbda9d

    
           if self.use_bias: 
        
             self.bias = self.add_variable( 
        
                 name='bias', 
        
                 shape=(self.filters,), 
        
                 initializer=self.bias_initializer, 
        
                 regularizer=self.bias_regularizer, 
        
                 trainable=True, 
        
                 dtype=self.dtype)

tensorflow/tensorflow/contrib/model_pruning/python/layers/core_layers.py

Lines 438 to 447 in 5fbda9d

    
           if self.use_bias: 
        
             self.bias = self.add_variable( 
        
                 'bias', 
        
                 shape=[ 
        
                     self.units, 
        
                 ], 
        
                 initializer=self.bias_initializer, 
        
                 regularizer=self.bias_regularizer, 
        
                 dtype=self.dtype, 
        
                 trainable=True)

tensorflow-jenkins · 2017-11-22T11:27:23Z

Can one of the admins verify this patch?

yifeif

Thank you @ZhengshengWei !

ZhengshengWei · 2017-11-23T02:44:24Z

I just changed docstring of functions. But Unit tests couldn't be passed. Some error logs are as follows. Additionally, I merged lastest 'upstream/master' into my branch. What should I do next? Thank anyone who helps me.

-----------------------------------------error logs-------------------------------------------------
/tmpfs/tmp/bazel/execroot/org_tensorflow/bazel-out/k8-py3-opt/bin/tensorflow/examples/adding_an_op/cuda_op_test.runfiles/org_tensorflow/tensorflow/tools/ci_build/gpu_build/parallel_gpu_execute: line 40: 30163 Segmentation fault      (core dumped) $@

@xla-rotation

Imported from GitHub PR openxla/xla#14792 related rocm part change is missing and internal CL is merged without check due to this openxla/xla@c40dbf2 @xla-rotation @gflegar @beckerhe Thanks in advance! Copybara import of the project: -- 0f4236ca8a3767666ce03713fd7ae9e4d1254e5c by Chao Chen <[email protected]>: fixed build due to openxla/xla@c40dbf2 Merging this change closes #14792 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14792 from ROCm:ci_20240711 0f4236ca8a3767666ce03713fd7ae9e4d1254e5c PiperOrigin-RevId: 651325280

@xla-rotation

Imported from GitHub PR openxla/xla#14792 related rocm part change is missing and internal CL is merged without check due to this openxla/xla@c40dbf2 @xla-rotation @gflegar @beckerhe Thanks in advance! Copybara import of the project: -- 0f4236ca8a3767666ce03713fd7ae9e4d1254e5c by Chao Chen <[email protected]>: fixed build due to openxla/xla@c40dbf2 Merging this change closes #14792 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14792 from ROCm:ci_20240711 0f4236ca8a3767666ce03713fd7ae9e4d1254e5c PiperOrigin-RevId: 650302604

@xla-rotation

Imported from GitHub PR openxla/xla#14792 related rocm part change is missing and internal CL is merged without check due to this openxla/xla@c40dbf2 @xla-rotation @gflegar @beckerhe Thanks in advance! Copybara import of the project: -- 0f4236ca8a3767666ce03713fd7ae9e4d1254e5c by Chao Chen <[email protected]>: fixed build due to openxla/xla@c40dbf2 Merging this change closes #14792 PiperOrigin-RevId: 651333429

revise docstring

e8d5c9a

googlebot added the cla: yes label Nov 22, 2017

yifeif approved these changes Nov 22, 2017

View reviewed changes

yifeif self-assigned this Nov 22, 2017

yifeif added kokoro:force-run Tests on submitted change awaiting testing (then merge) labels Nov 22, 2017

kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 22, 2017

Merge remote-tracking branch 'upstream/master' into addition

24e6dc4

Merge remote-tracking branch 'upstream/master' into addition

9aca4c6

sb2nov added the kokoro:force-run Tests on submitted change label Nov 29, 2017

kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 29, 2017

sb2nov added the kokoro:force-run Tests on submitted change label Nov 30, 2017

kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 30, 2017

sb2nov merged commit fa6a704 into tensorflow:master Nov 30, 2017

ZhengshengWei deleted the addition branch November 30, 2017 23:48

copybara-service Bot mentioned this pull request Jul 11, 2024

PR #14792: [ROCM ] hotfix ROCm build #71652

Merged

copybara-service Bot mentioned this pull request Jul 11, 2024

PR #14792: [ROCM ] hotfix ROCm build #71647

Closed

Navigation Menu

Repository navigation

modified convolution document - #14792

modified convolution document#14792
sb2nov merged 3 commits into
tensorflow:masterfrom
ZhengshengWei:addition

ZhengshengWei commented Nov 22, 2017

Uh oh!

tensorflow-jenkins commented Nov 22, 2017

Uh oh!

yifeif left a comment

Uh oh!

ZhengshengWei commented Nov 23, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	if self.use_bias:
	self.bias = self.add_variable(
	name='bias',
	shape=(self.filters,),
	initializer=self.bias_initializer,
	regularizer=self.bias_regularizer,
	trainable=True,
	dtype=self.dtype)

	if self.use_bias:
	self.bias = self.add_variable(
	'bias',
	shape=[
	self.units,
	],
	initializer=self.bias_initializer,
	regularizer=self.bias_regularizer,
	dtype=self.dtype,
	trainable=True)

Conversation

ZhengshengWei commented Nov 22, 2017

Uh oh!

tensorflow-jenkins commented Nov 22, 2017

Uh oh!

yifeif left a comment

Choose a reason for hiding this comment

Uh oh!

ZhengshengWei commented Nov 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhengshengWei commented Nov 23, 2017 •

edited

Loading