Repository navigation
NFC - minor spelling tweaks under compiler directory - #34958
Merged
tensorflow-copybara merged 3 commits intoDec 16, 2019
Merged
Conversation
Contributor
Author
|
Would it be possible to let me know if smaller PRs (e.g. 100 files per PR) are better for ease of review? I will split this into two PRs. |
kiszk
changed the title
mihaimaruseac
previously approved these changes
Dec 9, 2019
mihaimaruseac
left a comment
mihaimaruseac
left a comment
Contributor
There was a problem hiding this comment.
That is great! Thank you for the PR.
Did you use a script to do the fixing? If yes, can you please share it too?
| // instruction is removable for a fusion computation. | ||
| // | ||
| // Note that IsSafelyRemovable() is a necassarily condition to remove an | ||
| // Note that IsSafelyRemovable() is a necessarily condition to remove an |
tensorflow-bot
Bot
added
kokoro:force-run
mihaimaruseac
approved these changes
Dec 9, 2019
Contributor
Author
|
I use a script to list up potential candidates. The script lists up a lot of false positives. Finally, I manually find and fix them. An example of outputs |
Contributor
|
We might need to use the script internally to convert tooling that expects some of the same typos to exist. |
Contributor
Author
|
I use this script from https://qiita.com/debility/items/d3b24bc9a941241e82b8 |
Contributor
Author
|
I am working for other directories now. |
gbaned
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Dec 16, 2019
PiperOrigin-RevId: 285793343 Change-Id: I20bc2b8ca24d5fee4613f12abeba48957f80221f
This was referenced Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses minor spelling tweaks under
tensorflow/compilerdirectory. In addition,RELEASE.MDis also addressed.