Repository navigation
Option to config python lib path from env var - #5135
Conversation
|
@villasv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @meteorcloudy, @itsmeolivia and @tensorflower-gardener to be potential reviewers. |
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
@googlebot Done. |
|
CLAs look good, thanks! |
| PYTHON_LIB_PATH="$b" | ||
| fi | ||
| fi | ||
| if test -d "$PYTHON_LIB_PATH" -a -x "$PYTHON_LIB_PATH"; then |
There was a problem hiding this comment.
Why not an else branch? I guess this will only work with a single directory?
There was a problem hiding this comment.
The test is the same as before (it was applied to the b input variable. I think that should always be a single directory?)
I made a sepparate "if" branch so this tests lib path both in the env var and the cmd input cases.
|
Jenkins, test this please. |
Fix bad var echoing introduced by #5135
6 participants
The simplest way to give the option to configure python library path from environment variables, targeting the issue tensorflow/serving#216 about a scriptable complete configuration for tensorflow + serving.