Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #4 by ensuring asynchronous CefJSDialogCallback::Continue(...) calls (notably for onBeforeUnloadDialog(...) in windowless mode) are marshaled onto the CEF UI thread, matching CEF’s expected threading model and avoiding fallback/default JS dialog handling.
Changes:
- Marshal
CefJSDialogCallback::Continue(...)ontoTID_UIusingCefPostTaskwhen invoked off the UI thread. - Move the CEF clone target from
./cefto./references/cef. - Update ignore configuration related to the new
references/location (and add a new.ignorefile).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| native/CefJSDialogCallback_N.cpp | Posts Continue(...) to the CEF UI thread when needed. |
| clone_cef.sh | Clones CEF into references/cef instead of cef. |
| .ignore | Adds gitignore-style negation rules for references/ (effectiveness depends on tooling). |
| .gitignore | Updates ignored path from /cef to references/. |
Comments suppressed due to low confidence (1)
clone_cef.sh:15
TARGET_DIRnow points to${SCRIPT_DIR}/references/cef, but the script doesn't create the parent${SCRIPT_DIR}/referencesdirectory.git clone ... "${TARGET_DIR}"will fail ifreferences/doesn't already exist. Add amkdir -p "$(dirname "${TARGET_DIR}")"(or similar) before the clone.
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
TARGET_DIR="${SCRIPT_DIR}/references/cef"
CEF_REPO_URL="https://github.com/chromiumembedded/cef"
if [ -e "${TARGET_DIR}" ]; then
echo "${TARGET_DIR} already exists; skipping clone."
exit 0
fi
git clone "${CEF_REPO_URL}" "${TARGET_DIR}"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4