Skip to content

chore: apply 2.1 dead-file cleanup to master (#493 parity) - #523

Merged
navneetkumar-pim-webkul merged 1 commit into
masterfrom
chore/2.1-dead-file-cleanup
Jun 26, 2026
Merged

navneetkumar-pim-webkul merged 1 commit into
masterfrom
chore/2.1-dead-file-cleanup

Conversation

@navneetkumar-pim-webkul

Copy link
Copy Markdown
Collaborator

Summary

Mirrors the 2.1 housekeeping cleanup (#493 + related) onto master — removes 59 files that 2.1 deleted but master still carried. Brings master in line with 2.1's removed-file state.

Note: #514 (preselect locale/currency from .env on reinstall) is already in master via #515 — not included here.

What's removed

Group Files
In-repo AI-assistant skills + infra .github/skills/*, .{ai,claude,codex,cursor,kilocode}/skills symlinks, .github/workflows/skills-consistency.yml, bin/validate-skills.sh
Legacy upgrade guides + scripts UPGRADE-*.md, upgrade_*.sh
Dev instruction docs AGENTS.md, code-generation-instructions.md, code-review-instructions.md (+ .github copies), Features.md, CHANGE_IMPACT_CLASSIFICATION.md, bug_report.md
Orphan configs config/horizon.php, config/sitemap.php
Misc bin/codecept, patches.lock.json, public/forge, DataGrid/ExampleTest.php, stale build assets

Safety checks

  • laravel/horizon is not a dependency (neither master nor 2.1); no code references config('horizon') or config('sitemap') — both configs are orphan
  • git grep confirms no remaining code references any removed file (skills scripts, configs, upgrade scripts)
  • php artisan boots clean · Pint passes full repo · Installer suite 77 pass

Scope note

Pure file removals — no functional code changed. .github/skills/* were development skill docs extracted out of the repo in 2.1; removing them here keeps master consistent.

Mirror the 2.1 housekeeping cleanup onto master — remove 59 files 2.1
deleted but master still carried:

- In-repo AI-assistant skills + infra: .github/skills/*, .{ai,claude,codex,
  cursor,kilocode}/skills symlinks, .github/workflows/skills-consistency.yml,
  bin/validate-skills.sh
- Legacy upgrade guides + scripts: UPGRADE-*.md, upgrade_*.sh
- Dev instruction docs: AGENTS.md, code-generation-instructions.md,
  code-review-instructions.md (+ .github copies), Features.md,
  CHANGE_IMPACT_CLASSIFICATION.md, bug_report.md
- Orphan configs: config/horizon.php, config/sitemap.php
  (horizon not a dependency; no code references either config)
- Misc: bin/codecept, patches.lock.json, public/forge, DataGrid ExampleTest,
  stale build assets

No remaining code references the removed files; artisan boots clean.

(cherry picked from commit ee26135)
Copilot AI review requested due to automatic review settings June 26, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@navneetkumar-pim-webkul
navneetkumar-pim-webkul merged commit 82a8118 into master Jun 26, 2026
19 of 31 checks passed
@navneetkumar-pim-webkul
navneetkumar-pim-webkul deleted the chore/2.1-dead-file-cleanup branch June 26, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants