Repository navigation
fix(installer): restore composerProbePaths() — fixes 2 CI Pest failures on master - #526
Merged
Merged
Conversation
…trollerTest The 2.1 convergence merge (#525) brought in 2.1's InstallerControllerTest (which asserts a `composerProbePaths()` method and a bundled `bin/composer/composer.phar` probe) but kept master's InstallerController, which inlined the probe list and lacked that method — causing 2 CI Pest failures. Extract the probe list into composerProbePaths() (adding the bundled bin/composer/composer.phar path) and have resolveComposerBinary() iterate it, matching the test. Pure refactor — runtime behaviour unchanged except the extra bundled-phar probe. InstallerControllerTest: 7/7 pass. Pint clean.
kunal-kumar-dev
pushed a commit
to kunal-kumar-dev/unopim
that referenced
this pull request
Jul 6, 2026
…trollerTest (unopim#526) The 2.1 convergence merge (unopim#525) brought in 2.1's InstallerControllerTest (which asserts a `composerProbePaths()` method and a bundled `bin/composer/composer.phar` probe) but kept master's InstallerController, which inlined the probe list and lacked that method — causing 2 CI Pest failures. Extract the probe list into composerProbePaths() (adding the bundled bin/composer/composer.phar path) and have resolveComposerBinary() iterate it, matching the test. Pure refactor — runtime behaviour unchanged except the extra bundled-phar probe. InstallerControllerTest: 7/7 pass. Pint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master's Pest CI is red — 2 failures, both
InstallerController::resolveComposerBinary:it probes the bundled bin/composer/composer.pharit returns a php + phar argument prefix when only the bundled phar exists(1981 passed, 2 failed.)
Cause
The 2.1 convergence merge (#525) brought in 2.1's
InstallerControllerTest, which asserts:composerProbePaths()method exists, andbase_path('bin/composer/composer.phar').But the merge kept master's
InstallerController, which inlined the probe list insideresolveComposerBinary()and had nocomposerProbePaths()method → the test'sReflectionMethod($controller, 'composerProbePaths')blew up. (A test↔code mismatch from resolving that conflict in master's favor.)Fix
Extract the probe list into
composerProbePaths()(adding the bundledbin/composer/composer.pharpath) and haveresolveComposerBinary()iterate it — exactly 2.1's shape, which the test was written against. Pure refactor; runtime behaviour unchanged apart from the extra bundled-phar probe.Verification
InstallerControllerTest→ 7/7 pass (the 2 failing tests now green)Greens the Pest job on master.