Skip to content

ci: update node versions for cI - #732

Merged
ctavan merged 3 commits into
mainfrom
ci_node_20
Sep 8, 2023
Merged

ctavan merged 3 commits into
mainfrom
ci_node_20

Conversation

@broofa

@broofa broofa commented Sep 7, 2023

Copy link
Copy Markdown
Member

No description provided.

@ctavan

ctavan commented Sep 8, 2023

Copy link
Copy Markdown
Member

I updated the branch protection to expect the 20.x check to pass instead of 12.x

@ctavan
ctavan merged commit 462128b into main Sep 8, 2023
@ctavan
ctavan deleted the ci_node_20 branch September 8, 2023 10:31
@ctavan

ctavan commented Sep 8, 2023

Copy link
Copy Markdown
Member

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

We should also update the README for Node 20.x support…

@broofa

broofa commented Sep 8, 2023

Copy link
Copy Markdown
Member Author

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

Hmm... good point. I'll add 12.x back in.

[Breadcrumb: link to the debate on whether this sort of thing constitutes a breaking change.]

That said, our node support policy is "supported node releases + 1 prior version", right? So with 16.x slated for premature end-of-life on Monday, we should be able to drop support for 12 & 14 at our leisure.

zeekay pushed a commit to hanzoai/uuid that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants