Skip to content

save - #68

Closed
MarisaKirisame wants to merge 1 commit into
v8:mainfrom
MarisaKirisame:2020-12-24
Closed

save#68
MarisaKirisame wants to merge 1 commit into
v8:mainfrom
MarisaKirisame:2020-12-24

Conversation

@MarisaKirisame

Copy link
Copy Markdown

No description provided.

@MarisaKirisame
MarisaKirisame deleted the 2020-12-24 branch March 17, 2023 21:43
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
(cherry picked from commit dd3289d)

Bug: chromium:1321078
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I426327ffc3d7eebdb562c01a87039a93dfb79a88
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620836
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#80349}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676863
Reviewed-by: Dominik Inführ <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
Reviewed-by: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#68}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 16, 2023
This reverts commit 1e07ccf.

Original change's description:
> Revert "[M108-LTS][runtime] Fix handling of interceptors"
>
> This reverts commit 0425ca6.
>
> Reason for revert: Landed before merge approval
>
> Original change's description:
> > [M108-LTS][runtime] Fix handling of interceptors
> >
> > Drive-by: simplify creation of LookupIterator copies.
> >
> > (cherry picked from commit d125c73)
> >
> > Bug: chromium:1440695
> > Change-Id: Icadab9c8b682f87524eed4c508e27be3a8c5b2d7
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4537324
> > Commit-Queue: Igor Sheludko <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/main@{#87701}
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4567879
> > Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
> > Reviewed-by: Igor Sheludko <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/10.8@{v8#60}
> > Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> > Cr-Branched-From: 237de89-refs/heads/main@{#83672}
>
> Bug: chromium:1440695
> Change-Id: I531b18d578d5fada30e9af78c3ae4315827580c2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4580007
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Igor Sheludko <[email protected]>
> Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
> Cr-Commit-Position: refs/branch-heads/10.8@{v8#64}
> Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Bug: chromium:1440695
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ic996f523a654228e3e7802532d64993e819dfbbe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4603935
Reviewed-by: Igor Sheludko <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#68}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
reposynch Bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 21, 2024
Change-Id: I98be4c9604f63784b2a5fa970e63784be3772f47
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5198380
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#68}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
hubot pushed a commit that referenced this pull request Aug 27, 2024
The first call to ZeroExtendsWord32ToWord64 produces a correct result,
but leaves some incorrect values in phi_states_. To avoid incorrect
behavior, we should clear those values when starting anew.

I think that the performance impact of this change on compilation time
should be small, because calls to ZeroExtendsWord32ToWord64 are
infrequent. Here is a histogram showing, per function compiled in
Octane, how often this new code is run:

0: 74.7%
1: 13.1%
2: 6.3%
3: 2.5%
4 or 5: 1.7%
6 to 9: 0.9%
11 to 33: 0.8%

(cherry picked from commit 780d560)

Bug: b/356196918
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I00a9e74652025bf8a32cb083a6e01c0273e44043
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5766478
Commit-Queue: Seth Brenith <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#95528}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789878
Reviewed-by: Thibaud Michaud <[email protected]>
Reviewed-by: Seth Brenith <[email protected]>
Auto-Submit: Roger Felipe Zanoni da Silva (xWF) <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.0@{#68}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request Sep 20, 2024
Change-Id: Iab54e498bc67914d02f194dac0a83df7f310fdc2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5876955
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#68}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Oct 10, 2024
and allow d8-based tests for it.

(cherry picked from commit 9542895)

Fixed: 368241697
Change-Id: Iddc9f7e669de7a1d79dccbc99bcc5fb43dad67a1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5886728
Reviewed-by: Clemens Backes <[email protected]>
Reviewed-by: Matthias Liedtke <[email protected]>
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#96272}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5905241
Commit-Queue: Gyuyoung Kim (xWF) <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.6@{#68}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Jan 27, 2025
So far, CheckNumber(untagged phi) was always removed, but for a
holey float64, CheckNumber should fail on the hole nan.

Bug: chromium:389330329
(cherry picked from commit cc4c963)

Change-Id: I4bc634789e2d8d7f364e36b69dceeeb2886c54b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6198231
Reviewed-by: Olivier Flückiger <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Auto-Submit: Darius Mercadier <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.2@{#68}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Sep 18, 2025
…tion

The {FromStringLarge} implementation uses the allocated result as
temporary storage at first. This algorithm crucially relies on that
result having the right size. We do allocate it with the right size,
but a concurrent mutator could immediately muck with it; so guard
against that with a CHECK.

(cherry picked from commit eba1812)

Fixed: 427600180
Change-Id: I19366ae8562aefd21af1d850df4155c016cdb904
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6680320
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#101119}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6937656
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Roger Felipe Zanoni da Silva (xWF) <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.8@{#68}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Apr 9, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8685032470683953921

Change-Id: I71b0f5b380f880c350e79bf8d242fd8f008f1c99
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7742000
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.4@{#68}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant