Skip to content

Runtime: Fix typo in doc - #17890

Closed
girishji wants to merge 1 commit into
vim:masterfrom
girishji:typo
Closed

girishji wants to merge 1 commit into
vim:masterfrom
girishji:typo

Conversation

@girishji

Copy link
Copy Markdown
Contributor

Fix typo.

M  runtime/doc/builtin.txt
@zeertzjq

Copy link
Copy Markdown
Member

Why is this a typo? ? doesn't need to be escaped inside [] and \ is not a valid cmdline type.

@girishji

Copy link
Copy Markdown
Contributor Author

Does ?foo open a menu though, after vim --clean and :autocmd CmdlineChanged [:/?] call wildtrigger()?

@zeertzjq

Copy link
Copy Markdown
Member

Hmm, I may have tested this incorrectly.

@chrisbra

chrisbra commented Aug 6, 2025

Copy link
Copy Markdown
Member

Hmm, I may have tested this incorrectly.

I also wondered why this was required. But it needs to be escaped because of :h file-pattern. :auto means we are using glob like patterns, and as such the ? must be escaped to match the ? literally.

Thanks, I include it.

@chrisbra chrisbra closed this in f7deb81 Aug 6, 2025
@girishji

girishji commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

Thanks!

@girishji
girishji deleted the typo branch August 6, 2025 20:38
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 6, 2025
The '?' needs to be escaped, because the autocommand is using
file-patterns (glob like) and not a regex). See :h file-pattern

closes: vim/vim#17890

vim/vim@f7deb81

Co-authored-by: Girish Palya <[email protected]>
yochem pushed a commit to yochem/neovim that referenced this pull request Aug 23, 2025
The '?' needs to be escaped, because the autocommand is using
file-patterns (glob like) and not a regex). See :h file-pattern

closes: vim/vim#17890

vim/vim@f7deb81

Co-authored-by: Girish Palya <[email protected]>
sahinf pushed a commit to sahinf/vim that referenced this pull request Sep 7, 2025
The '?' needs to be escaped, because the autocommand is using
file-patterns (glob like) and not a regex). See :h file-pattern

closes: vim#17890

Signed-off-by: Girish Palya <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
dundargoc pushed a commit to dundargoc/neovim that referenced this pull request Sep 27, 2025
The '?' needs to be escaped, because the autocommand is using
file-patterns (glob like) and not a regex). See :h file-pattern

closes: vim/vim#17890

vim/vim@f7deb81

Co-authored-by: Girish Palya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants