Repository navigation
Conversation
Problem: Inside a block that is not executed, "if 0" for one, the
lines that ":command", ":autocmd", ":class", ":interface",
":enum" and ":loadkeymap" read are read as commands, since
none of them is executed while skipping. An interface with
"def M(): number" in it ends the script with E1057, and a
line of a keymap with E488. A ":source ++dryrun" hits this
at the script level.
Solution: Execute those commands while skipping, like ":function",
and only read the lines they own then.
Assisted-by: Claude
Signed-off-by: Hirohito Higashi <[email protected]>
h-east
force-pushed
the
skip-command-block
branch
from
September 20, 2026 00:35
447e50c to
4db330f
Compare
h-east
changed the title
Member
|
thanks |
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Sep 26, 2026
… commands (#42102) Problem: "if 0" condition not correctly skipped for :command, :autocmd, :class, :interface, :enum and :loadkeymap Solution: Skip those commands and discard the blocks they read (Hirohito Higashi). closes: vim/vim#21349 vim/vim@f3dc0fe Co-authored-by: Hirohito Higashi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #21331