Skip to content

PR template duplicates the commit message - #21454

Closed
h-east wants to merge 1 commit into
vim:masterfrom
h-east:rework-pr-template
Closed

h-east wants to merge 1 commit into
vim:masterfrom
h-east:rework-pr-template

Conversation

@h-east

@h-east h-east commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
Problem:  The PR template repeats what the commit message provides and
          its checklist must be edited instead of ticked.  AGENTS.md
          shows a patch number in the subject.
Solution: Describe the commit message in a comment, use one checkbox
          per choice and drop the patch number.

related: #21321

AI assistance

  • AI involvement is disclosed in the commit message
  • No AI was used

Checklist

  • The commit message follows the Problem/Solution form above
  • Signed-off-by: trailer is present (git commit -s), recommended but not required

Tests

  • Tests were added
  • Existing tests cover the change
  • The change cannot be tested (explain below)

Documentation

  • Documentation under runtime/doc/ was updated
  • No documentation update is needed

Anything reviewers should know

Since only the template is being modified, no testing is required.

Problem:  The PR template asks again for what the commit message
          already provides as the title and description, and its
          checklist items list alternatives in one line that must be
          edited instead of ticked.  AGENTS.md shows a patch number in
          the subject, which is added only when merging.
Solution: Explain the commit message form in a comment, give each
          alternative its own checkbox, and drop the patch number from
          the AGENTS.md example.

Assisted-by: Claude
Signed-off-by: Hirohito Higashi <[email protected]>
@h-east h-east changed the title PR template duplicates the commit message and needs edits to fill in PR template duplicates the commit message Oct 5, 2026
@h-east

h-east commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

(I actually wrote a PR description using the contents of the template I submitted in the pull request.)

@chrisbra

chrisbra commented Oct 6, 2026

Copy link
Copy Markdown
Member

okay, thanks

@chrisbra chrisbra closed this in 5979d7d Oct 6, 2026
@h-east
h-east deleted the rework-pr-template branch October 6, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants