Skip to content

fix: fix ESM entryChunk depends on the runtimeChunk hash - #19570

Merged
alexander-akait merged 1 commit into
mainfrom
fix/issue-19439
May 30, 2025
Merged

fix: fix ESM entryChunk depends on the runtimeChunk hash#19570
alexander-akait merged 1 commit into
mainfrom
fix/issue-19439

Conversation

@xiaoxiaojx

@xiaoxiaojx xiaoxiaojx commented May 29, 2025 •
edited by alexander-akait
Loading

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?
fixes #19439

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No
What needs to be documented once your changes are merged?

No

@codspeed

codspeed Bot commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #19570 will degrade performances by 20%

Comparing fix/issue-19439 (4fdc0d2) with main (1b34181)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 128 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "cache-filesystem", scenario '{"name":"mode-development","mode":"development"}' 1.2 s 1.4 s -11.51%
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 62.2 ms 47.2 ms +31.92%
❌ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 49 ms 61.3 ms -20%
⚡ benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.9 ms 11.8 ms ×5.2
⚡ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 51.7 ms 11.3 ms ×4.6

@xiaoxiaojx xiaoxiaojx changed the title [WIP] fix: fix the case where an ESM entryChunk depends on the runtimeChunk… fix: fix ESM entryChunk depends on the runtimeChunk hash May 29, 2025
@xiaoxiaojx
xiaoxiaojx force-pushed the fix/issue-19439 branch 5 times, most recently from c2ee7a5 to 86d0942 Compare May 30, 2025 09:12
@alexander-akait

alexander-akait commented May 30, 2025

Copy link
Copy Markdown
Member

Good job, thank you

@alexander-akait
alexander-akait merged commit e805dc1 into main May 30, 2025
@alexander-akait
alexander-akait deleted the fix/issue-19439 branch May 30, 2025 12:30
3ru added a commit to 3ru/webpack that referenced this pull request Jun 2, 2025
@3ru
refactor: integrate getChunkInfo helper from webpack#19570
72511fb
3ru pushed a commit to 3ru/webpack that referenced this pull request Jul 1, 2025
@xiaoxiaojx @3ru
fix: fix the case where an ESM entryChunk depends on the runtimeChunk…
71df2fb 
… hash (webpack#19570)
@xiaoxiaojx xiaoxiaojx mentioned this pull request Mar 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Main chunk points to the wrong runtime chunk when using Module Federation

2 participants

@xiaoxiaojx @alexander-akait