Repository navigation
Conversation
Contributor
|
@mohsen1 Please review the following output log for errors: Show remaining errorsSee complete report here. |
27 tasks done
mohsen1
commented
Mar 26, 2018
| @@ -0,0 +1,319 @@ | |||
| declare module '*.json'; | |||
| declare module 'webpack-cli'; | |||
| declare module 'tapable' { | |||
Contributor
Author
There was a problem hiding this comment.
this declaration will go away once DefinitelyTyped/DefinitelyTyped#24527 is merged
Contributor
There was a problem hiding this comment.
Unfortunately I didn't check it earlier but there are errors in the type definitions. If context is defined, then the first argument is not T1 but the context.
ZuBB
reviewed
Mar 26, 2018
| "simple-git": "^1.65.0", | ||
| "sinon": "^2.3.2", | ||
| "style-loader": "^0.19.1", | ||
| "typescript": "^2.9.0-dev.20180325", |
There was a problem hiding this comment.
maybe its better to start with stable release?
Contributor
Author
There was a problem hiding this comment.
Fair point. With this work I've seen some bugs in TypeScript itself. Hoping they're fixed in the nightly builds. We should not go to master with a nightly build :)
ooflorent
suggested changes
Mar 27, 2018
| let _this = this; | ||
| const start = _this.profile && Date.now(); | ||
| const currentProfile = _this.profile && {}; | ||
| let __this = this; |
Contributor
There was a problem hiding this comment.
Could you remove this statement and replace _this by this? It should be possible because the code below uses arrow functions
|
|
||
| assignIndex(module) { | ||
| const _this = this; | ||
| const __this = this; |
Contributor
There was a problem hiding this comment.
Same here. this should be safe thanks to arrow functions.
|
|
||
| this.running = false; | ||
|
|
||
| // Added to make TypeScript happy |
Contributor
There was a problem hiding this comment.
This type of comment is not needed. Property should always be defined in order to avoid v8 transitions
| }; | ||
| for (let chunkId of Object.keys(records.chunkHashs)) { | ||
| chunkId = isNaN(+chunkId) ? chunkId : +chunkId; | ||
| chunkId = isNaN(+chunkId) ? chunkId : String(+chunkId); |
Contributor
There was a problem hiding this comment.
chunkId is either a string or number.
| normalModuleFactory.hooks.createGenerator | ||
| .for("javascript/auto") | ||
| .tap("JavascriptModulesPlugin", options => { | ||
| // @ts-ignore Expected 0 arguments, but got 1. |
Contributor
There was a problem hiding this comment.
Could you fix the constructor instead?
|
|
||
| // TODO: moved from Module.prototype to make TypeScript happy | ||
| // Not sure if this is the right thing to do | ||
| identifier() { |
Contributor
There was a problem hiding this comment.
These should be properties not methods
| module.exports = function objectToMap(obj) { | ||
| return new Map(Object.keys(obj).map(key => [key, obj[key]])); | ||
| // @ts-ignore | ||
| return new Map(Object.keys(obj).map(key => [key, obj[key]])); |
Contributor
There was a problem hiding this comment.
nit: Indentation is wrong
This was referenced Mar 27, 2018
Contributor
Author
|
Closing this PR as I'm making smaller PRs to address all those issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #6862 and not intended for merging.