Repository navigation
Initialize fileTimestamps and contextTimestamps in Compilation - #6883
Merged
Merged
Conversation
Contributor
|
It looks like that code was not dead 😕 |
Contributor
Author
|
I can't follow what's going on here. How Compiler and Compilation classes are related? |
Contributor
|
https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L428-L438 |
sokra
requested changes
Mar 28, 2018
sokra
left a comment
sokra
left a comment
Member
There was a problem hiding this comment.
This code is definitely not dead, it's pretty important.
The timestamps are set by the Watching or by the CachePlugin.
Maybe initialize them in the constructor to undefined
added 2 commits
March 28, 2018 10:08
Contributor
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
mohsen1
changed the title
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
approved these changes
Mar 28, 2018
sokra
approved these changes
Mar 28, 2018
27 tasks done
…code # Conflicts: # lib/Compilation.js
sokra
approved these changes
Mar 29, 2018
Member
|
Thanks |
mhegazy
added a commit
to mhegazy/webpack
that referenced
this pull request
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
no
If relevant, link to documentation update:
Summary
this.fileTimestamps && this.contextTimestampsis always falsy inCompilation. I looked into Tapable too and those don't exist there either. I seefileTimestampsinCompilerclass. Is that related?Does this PR introduce a breaking change?
Other information
Related to #6862