Repository navigation
Simplify cachedMerge - #7013
Merged
Merged
Simplify cachedMerge#7013
Conversation
ooflorent
commented
Apr 10, 2018
| } | ||
| const cachedMerge = innerCache.get(second); | ||
| if (cachedMerge !== undefined) return cachedMerge; | ||
| const prevMerge = innerCache.get(second); |
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
montogeek
approved these changes
Apr 10, 2018
sokra
reviewed
Apr 11, 2018
| const cachedMerge = (first, ...args) => { | ||
| if (args.length === 0) return first; | ||
| if (args.length > 1) { | ||
| return cachedMerge(first, cachedMerge(...args)); |
Contributor
There was a problem hiding this comment.
But not correct!
sokra
approved these changes
Apr 11, 2018
Member
|
Thanks |
27 tasks done
mhegazy
added a commit
to mhegazy/webpack
that referenced
this pull request
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
no
If relevant, link to documentation update:
N/A
Summary
cachedMergeis only called with 2 two arguments. It doesn't need to recursive.Does this PR introduce a breaking change?
no