Repository navigation
Misc docblock improvements - #6306
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for your PR. Note that there are now some PHPStan errors. Also, are there any more such cases to fix? It would be easier to fix everything at once. |
There was a problem hiding this comment.
Pull request overview
Adds missing DocBlocks to improve inline documentation and static analysis for the Dispatcher Subcommand class and its factory usage.
Changes:
- Added DocBlocks for
Subcommandproperties and constructor parameters. - Refined
CommandFactory::create_subcommand()$parentparameter type frommixedtoRootCommand|CompositeCommand.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| php/WP_CLI/Dispatcher/Subcommand.php | Adds DocBlocks for properties and the constructor to improve readability/IDE support. |
| php/WP_CLI/Dispatcher/CommandFactory.php | Tightens DocBlock type for $parent when creating Subcommand instances. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Subcommand class
Subcommand classCo-authored-by: Pascal Birchler <[email protected]>
Fixed: Missing DocBlocks for Class Constructors and Properties #6305