Skip to content

Renaming values in persistent-template - #1203

Merged
parsonsmatt merged 2 commits into
yesodweb:matt/pre-template-removalfrom
danbroooks:th-rename-variables
Mar 22, 2021
Merged

parsonsmatt merged 2 commits into
yesodweb:matt/pre-template-removalfrom
danbroooks:th-rename-variables

Conversation

@danbroooks

@danbroooks danbroooks commented Mar 15, 2021 •

Copy link
Copy Markdown
Contributor

Refactors some variable names in TH.hs as a contribution towards #1156


After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@danbroooks danbroooks changed the title Rename entDef and fieldDef values Renaming values persistent-template Mar 15, 2021
@danbroooks danbroooks changed the title Renaming values persistent-template Renaming values persistent-template Mar 15, 2021
@danbroooks danbroooks changed the title Renaming values persistent-template Renaming values in persistent-template Mar 15, 2021

@parsonsmatt parsonsmatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Thank you! This is awesome.

@parsonsmatt
parsonsmatt changed the base branch from master to matt/pre-template-removal March 22, 2021 22:31
@parsonsmatt
parsonsmatt merged commit f975100 into yesodweb:matt/pre-template-removal Mar 22, 2021
parsonsmatt added a commit that referenced this pull request Mar 22, 2021
* Renaming values in persistent-template (#1203)

* Rename entDef and fieldDef values

* Update changelog

* tidy up changelog

Co-authored-by: Dan Brooks <[email protected]>
@danbroooks
danbroooks deleted the th-rename-variables branch April 22, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants