Skip to content

commit langref.html.in to source control instead of downloading it - #2000

Merged
techatrix merged 4 commits into
masterfrom
techatrix/no-langref-download
Aug 22, 2024
Merged

techatrix merged 4 commits into
masterfrom
techatrix/no-langref-download

Conversation

@techatrix

@techatrix techatrix commented Aug 16, 2024 •

Copy link
Copy Markdown
Member

#1409 was mistake

#2000 🎉

@nektro

nektro commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

out of curiosity, why do you feel it was a mistake?

@techatrix

Copy link
Copy Markdown
Member Author

out of curiosity, why do you feel it was a mistake?

  • various package distributions needed workarounds because the build phase can't just randomly access the internet
  • the downloaded langref file is not properly cached which means that you can't build ZLS on the next day without internet
  • the downloaded langref file is not pinned by commit hash which hurts reproducibility

ziglang/zig#17895 is the solution.

@techatrix
techatrix force-pushed the techatrix/no-langref-download branch from c4e4bdd to 2a40ac6 Compare August 16, 2024 19:16
@nektro

nektro commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

ah makes sense, i mistakenly assumed 17895 was already implemented

@techatrix
techatrix force-pushed the techatrix/no-langref-download branch from 2a40ac6 to 8f48671 Compare August 22, 2024 15:36
@techatrix
techatrix merged commit b481aae into master Aug 22, 2024
@BratishkaErik

Copy link
Copy Markdown
Contributor

Thank you very much from GURU maintainer!

gentoo-bot pushed a commit to gentoo/guru that referenced this pull request Aug 24, 2024
It's now commited in ZLS repo instead, see
zigtools/zls#2000 .

Signed-off-by: Eric Joldasov <[email protected]>
@techatrix
techatrix deleted the techatrix/no-langref-download branch August 24, 2024 17:53
@bmwiedemann

Copy link
Copy Markdown

Is there a plan for a release with this fix? How far away would that approximately be?

@nektro

nektro commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

releases are paired with zig releases so there won't one until 0.14. using zls master requires building from source or zigup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants