Repository navigation
feat: add self-signed certificate init container - #141
Merged
Merged
Conversation
eliobischof
marked this pull request as ready for review
November 10, 2023 15:16
Contributor
|
Great to see this back in the works :) Thanks, @PurseChicken and @eliobischof ! |
stebenz
approved these changes
Nov 13, 2023
kleberbaum
pushed a commit
to fhkit/zitadel-charts
that referenced
this pull request
May 24, 2024
* Add self signed init container enabled with selfSignedCert in values. * reorder comment * zitadel#133 * zitadel#136 * minor improvements * use sslip * fix: probes with enabled tls * bump zitadel version * use sslip * use sslip * test selfSigned.enabled * bump chart testing action * only probe on http * increase timeout --------- Co-authored-by: PurseChicken <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of the changes in #141 it adds an example and test for
zitadel.selfSigned.enabled=true.Also, it uses 127.0.0.1.sslip.io instead of localhost so ingress and TLS are easier testable.
Definition of Ready