Repository navigation
lightbox test: Skip a no-hero test, pending rework for new page transitions - #1741
Merged
Merged
Conversation
Member
|
LGTM! Please merge at will once CI passes. |
…itions This test relies on background assumptions about how the "back" page transition work which are true of the current default transitions on Android (the default target platform of tests), but are broken by the upcoming introduction of predictive back: flutter/flutter#165832 (comment) For a quick unblocking of the upstream change, skip the test. In principle there's no reason a test like this can't work with the upcoming upstream behavior; it'll just need to work a little differently. But leave that for a follow-up change.
|
Thank you guys! |
auto-submit Bot
pushed a commit
to flutter/tests
that referenced
this pull request
Jul 24, 2025
Picking up a fix discussed here flutter/flutter#165832 (comment) and landed in Zulip here zulip/zulip-flutter#1741.
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2025
#172733) For #165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
flutter#172733) For flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter#172733) For flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter#172733) For flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter#172733) For flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter#172733) For flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
…… (#172733) For flutter/flutter#165832, picks up the test change from zulip/zulip-flutter#1741 that was bumped in the `tests` repo in flutter/tests#464.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test relies on background assumptions about how the "back" page transition work which are true of the current default transitions on Android (the default target platform of tests), but are broken by the upcoming introduction of predictive back:
flutter/flutter#165832 (comment)
For a quick unblocking of the upstream change, skip the test.
In principle there's no reason a test like this can't work with the upcoming upstream behavior; it'll just need to work a little differently. But leave that for a follow-up change.