Repository navigation
feat: add code samples and tests for overlay creation - #39
Conversation
product-auto-label
Bot
added
the
api: transcoder
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
the
samples
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 5 5
Lines 1581 1581
Branches 61 61
=======================================
Hits 1521 1521
Misses 59 59
Partials 1 1 Continue to review full report at Codecov.
|
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
Just a small nit, we usually hyphen-case JavaScript files, so:
create-job-with-static-overlay.js
| @@ -0,0 +1,119 @@ | |||
| /** | |||
| * Copyright 2021, Google, Inc. | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
There was a problem hiding this comment.
nit: we usually hyphen case our Node.js samples.
There was a problem hiding this comment.
Ack. Do I need to change this? I will then have to rename every .js file in the samples.
🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.2.0...v1.3.0) (2021-03-15) ### Features * **samples:** add code samples and tests for overlay creation ([#39](https://www.github.com/googleapis/nodejs-video-transcoder/issues/39)) ([47686fa](https://www.github.com/googleapis/nodejs-video-transcoder/commit/47686fa17c5e5164f6d5f5f37f09d37bd9844cc3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 participants
b:181782257