NodeTodo

430 posts

NodeTodo

@NodeTodo

Free and public gatherings for people that want to contribute to Node.js.

Joined August 2016

RepliesReplies RepostsReposts MediaMedia

Log in or sign up for X

See what’s happening and join the conversation

Continue with phone

or

Log in with username or email

Terms·Privacy·Cookies·Accessibility·US TIDA·Ads Info·© 2026 X Corp.

NodeTodo
@NodeTodo
Nov 19, 2018
Oh hey, congratulations @blacksun1!
github.com
test: remove unused function arguments in async-hooks tests · nodejs/node@738e076
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: https://github.com/nodejs/node/pull/24406 Reviewed-By: Weijia Wang
NodeTodo
@NodeTodo
Nov 17, 2018
Oh hey, congratulations Julia McGeoghan!
github.com
test: use destructuring and remove unused arguments · nodejs/node@07a7bf7
Use destructuring consistently and remove unused function arguments in test-pipewrap.js PR-URL: https://github.com/nodejs/node/pull/24375 Reviewed-By: Rich Trott R...
NodeTodo
@NodeTodo
Nov 12, 2018
Oh hey, I'm almost a year late on catching this one, but congratulations Seth Greylyn (who is probably @SethGreylyn)!
github.com
test: replace assert.throws w/ common.expectsError · nodejs/node@5201055
PR-URL: https://github.com/nodejs/node/pull/17091 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinc...
1
NodeTodo
@NodeTodo
Nov 12, 2018
Oh hey, congratulations Paul Hodgson (who is probably @prhodgson1)!
github.com
test: remove unused parameters in function definition · nodejs/node@49b0f7f
Remove unused parameters triggerAsyncId and resource from oninit function in test-async-await.js. PR-URL: https://github.com/nodejs/node/pull/24268 Reviewed-By: Weijia Wang
NodeTodo
@NodeTodo
Nov 11, 2018
Oh hey, congratulations, Saurabh Siddhu!
test: create files and directories in the tmp directory instead of fixture directory by saurabhSi...
From github.com