Repository navigation
Merge more Flutter debug tests to speed up test runs - #6168
Merged
Merged
Conversation
DanTup
added
the
is testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## merge-debug-tests #6168 +/- ##
=====================================================
- Coverage 70.87% 70.77% -0.11%
=====================================================
Files 170 170
Lines 13158 13158
Branches 2649 2649
=====================================================
- Hits 9326 9312 -14
- Misses 3314 3325 +11
- Partials 518 521 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Spawning a real Flutter app is very slow, so combining some of these tests to check multiple things speeds up the whole run significantly. See #6165
DanTup
force-pushed
the
merge-debug-tests-2
branch
from
September 5, 2026 14:52
73e8a06 to
5dc2a55
Compare
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
Spawning a real Flutter app is very slow, so combe these to have a single launch. See #6165
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to test code/test fixtures and the updated assertions and control flow appear consistent and complete for both device and web paths.
Pull request overview
This PR speeds up CI by merging several Flutter “flutter run” debug integration tests so fewer real Flutter apps need to be spawned, while still validating the same debugger behaviours (stepping, frame categorisation, and error output).
Changes:
- Added a
print()call to the SDK-throwing Flutter test app to provide a reliable stepping target into the SDK. - Consolidated SDK/external/local library stepping + frame-category assertions into fewer combined tests (with device-vs-web branching where needed).
- Merged exception-output metadata assertions and structured error rendering checks into a single test.
File summaries
| File | Description |
|---|---|
| src/test/test_projects/flutter_hello_world/lib/throw_in_sdk_code.dart | Adds a print() call used as a breakpoint/step-in target for SDK stepping tests. |
| src/test/flutter_debug/flutter_run.test_device_and_web.test.ts | Merges multiple Flutter debug tests into fewer runs while keeping coverage for stepping + frame categories and error/structured output assertions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
Spawning a real Flutter app is very slow, so combe these to have a single launch. See #6165
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawning a real Flutter app is very slow, so combining some of these tests to check multiple things speeds up the whole run significantly.
See #6165