Repository navigation
Merge some Flutter debug tests to speed up test runs - #6167
Conversation
DanTup
added
is testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6167 +/- ##
==========================================
+ Coverage 70.83% 70.87% +0.04%
==========================================
Files 170 170
Lines 13158 13158
Branches 2649 2649
==========================================
+ Hits 9320 9326 +6
+ Misses 3319 3314 -5
+ Partials 519 518 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Spawning a real Flutter app is very slow, so combining some of these tests to check multiple things speeds up the whole run significantly. See #6165
156a47e to
0f3a1a8
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The updated noDebug test introduces an un-awaited waitForEvent("stopped") that schedules a long timeout timer and can keep the test process alive unnecessarily.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR restructures Flutter debug integration tests to reduce overall CI runtime by combining scenarios that previously required multiple full Flutter app launches, and by converting some end-to-end assertions into configuration-level assertions where appropriate.
Changes:
- Merged multiple Flutter “test device” scenarios into fewer test runs (platform/brightness + theme re-send; combined expression evaluation cases).
- Converted Flutter custom tool tests from “spawn and assert tool executed” to “assert resolved launch config contains the expected custom tool/toolArgs”.
- Combined “noDebug expected services” with “does not stop at breakpoints” and merged breakpoint-condition coverage into a single test.
File summaries
| File | Description |
|---|---|
| src/test/flutter_debug/flutter_run.test_device.test.ts | Consolidates slow “only test device” Flutter run tests and replaces custom-tool end-to-end checks with launch-config assertions. |
| src/test/flutter_debug/flutter_run.test_device_and_web.test.ts | Merges noDebug/breakpoint/service checks and consolidates breakpoint-condition + local-variable/evaluateName assertions to reduce repeated app launches. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Spawning a real Flutter app is very slow, so combining some of these tests to check multiple things speeds up the whole run significantly.
See #6165